From: Marco Costalba <mcostalba@gmail.com>
Date: Sat, 21 Oct 2006 19:33:14 GMT
Subject: Re: [PATCH 2/2] Remove dead code after direct graph drawing
Message-ID: <e5bfff550610211233i1af1c6a5nf2d50a6759dab061@mail.gmail.com>
In-Reply-To: <200610211740.26128.Josef.Weidendorfer@gmx.de>

>
> On the first pass down, the memory increases by around 26 MB,
> which could by correct, as you do setupData() lazy (no idea what
> this function does...).

Populates the list view item and calculates (only calculation not
drawing) the graph of the item (see Git::updateLanes() )

> >
> > I'm not sure it depends on your patch though.
>
> Can you compare with/without my patch?

Yes. You are right, I have a memory increase also without your last patch.

>
> How did you check for leaks in the past?
> Did you try valgrind (memcheck or massif)?
>

I tried with valgrind but with little success due to a lot of noise
from qt libraries. Perhaps I was not using it right.


Sorry for the noise

Marco