Re: [PATCH] git-commit: revamp the git-commit semantics.
- From
- Marco Costalba <mcostalba@gmail.com>
- Date
- Feb 5, 2006, 13:36 UTC
- Message-ID
- <e5bfff550602050536j73f1091dq9afae232f574d0b4@mail.gmail.com>
- In-Reply-To
- <7vpsm2hzng.fsf@assigned-by-dhcp.cox.net>
On 2/5/06, Junio C Hamano <junkio@cox.net> wrote:
Show 8 quoted lines
> I am addressing people who participated with their valuable > inputs to the earlier "git commit" discussion. > > Here is my first cut. I'd appreciate to hear from both > git-experienced people and git newcomers how comfortable this > new implementation is. Improvement patches on top of this are > certainly appreciated. >
I think the new semantics is clear and better then old one, especially for people coming from different scm systems.
Unfortunately it breaks qgit commit functionality. So I would like to ask _how_ do you plan to update main line.
I would like to update qgit also today, but it is impossible because "git-commit -i" _currently_ raises an error. So I am just wondering if adding a temporary -i "no op" option to _current_ git-commit, until semantics change is released could be done.
Adding a -i "place holder" option to _current_ git-commit has the following advantages:
1) No functionality change and 100% compatibility with current git-commit use. 2) Give people time to update tools/script in the mean time 3) When the real patch will be released all the (modified) tools will be automatically compatible.
What do you think?
Marco