Re: [PATCH] help: allow redirecting to help for aliased command

From: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Date: Sep 28, 2018, 07:44 UTC
Message-ID: <e59fd7e3-7755-79b9-4b73-1da991db39b6@rasmusvillemoes.dk>
In-Reply-To: <CACsJy8AQbJPVNtcVEsLH-iiXw2TPABr3LsgZ779h3KMvR98yZQ@mail.gmail.com>

On 2018-09-26 17:19, Duy Nguyen wrote:

Show 21 quoted lines

> On Wed, Sep 26, 2018 at 4:42 PM Taylor Blau <me@ttaylorr.com> wrote:
>>> +
>>> +             /*
>>> +              * We use split_cmdline() to get the first word of the
>>> +              * alias, to ensure that we use the same rules as when
>>> +              * the alias is actually used. split_cmdline()
>>> +              * modifies alias in-place.
>>> +              */
>>> +             count = split_cmdline(alias, &argv);
>>> +             if (count < 0)
>>> +                     die("Bad alias.%s string: %s", cmd,
>>> +                         split_cmdline_strerror(count));
>>
>> Please wrap this in _() so that translators can translate it.
> 
> Yes! And another nit. die(), error(), warning()... usually start the
> message with a lowercase letter because we already start the sentence
> with a prefix, like
> 
> fatal: bad alias.blah blah
>

I'll keep these points in mind, but this was pure copy-paste from git.c.

Rasmus