Re: [PATCH] help: allow redirecting to help for aliased command

From: Duy Nguyen <pclouds@gmail.com>
Date: Sep 26, 2018, 15:19 UTC
Message-ID: <CACsJy8AQbJPVNtcVEsLH-iiXw2TPABr3LsgZ779h3KMvR98yZQ@mail.gmail.com>
In-Reply-To: <20180926143708.GD25697@syl>

On Wed, Sep 26, 2018 at 4:42 PM Taylor Blau <me@ttaylorr.com> wrote:

Show 13 quoted lines

> > +
> > +             /*
> > +              * We use split_cmdline() to get the first word of the
> > +              * alias, to ensure that we use the same rules as when
> > +              * the alias is actually used. split_cmdline()
> > +              * modifies alias in-place.
> > +              */
> > +             count = split_cmdline(alias, &argv);
> > +             if (count < 0)
> > +                     die("Bad alias.%s string: %s", cmd,
> > +                         split_cmdline_strerror(count));
>
> Please wrap this in _() so that translators can translate it.

Yes! And another nit. die(), error(), warning()... usually start the message with a lowercase letter because we already start the sentence with a prefix, like

fatal: bad alias.blah blah

-- 
Duy