[PATCH v2 6/9] reftable/stack: do not die when fsyncing lock file files
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Aug 5, 2024, 13:08 UTC
- Message-ID
- <e411e14904b4381e7631662c54d22024e04c3996.1722862822.git.ps@pks.im>
- In-Reply-To
- <cover.1722862822.git.ps@pks.im>
We use `fsync_component_or_die()` when committing an addition to the "tables.list" lock file, which unsurprisingly dies in case the fsync fails. Given that this is part of the reftable library, we should never die and instead let callers handle the error.
Adapt accordingly and use `fsync_component()` instead.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- reftable/stack.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/reftable/stack.c b/reftable/stack.c index 07e7ffc6b9..9ca549294f 100644 --- a/reftable/stack.c +++ b/reftable/stack.c @@ -674,8 +674,11 @@ int reftable_addition_commit(struct reftable_addition *add) goto done; } - fsync_component_or_die(FSYNC_COMPONENT_REFERENCE, lock_file_fd, - get_tempfile_path(add->lock_file)); + err = fsync_component(FSYNC_COMPONENT_REFERENCE, lock_file_fd); + if (err < 0) { + err = REFTABLE_IO_ERROR; + goto done; + } err = rename_tempfile(&add->lock_file, add->stack->list_file); if (err < 0) {
-- 2.46.0.dirty