Re: [PATCH 6/8] reftable/stack: use lock_file when adding table to "tables.list"

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 1, 2024, 08:40 UTC
Message-ID: <ZqtKGhYcri7ClCbH@tanuki>
In-Reply-To: <fpli326ssfh66sojj4bqn2ztaks3lceqce7nwb4jzrducpvfxz@uoeabcbebaez>

On Wed, Jul 31, 2024 at 06:02:41PM -0500, Justin Tobler wrote:

Show 11 quoted lines

> On 24/07/31 04:15PM, Patrick Steinhardt wrote:
> > @@ -674,13 +675,14 @@ int reftable_addition_commit(struct reftable_addition *add)
> >  		goto done;
> >  	}
> >  
> > -	err = fsync_component(FSYNC_COMPONENT_REFERENCE, lock_file_fd);
> > +	err = fsync_component(FSYNC_COMPONENT_REFERENCE,
> > +			      get_lock_file_fd(&add->tables_list_lock));
> 
> I might be missing something, but is there a reason we have to get the
> lock file fd again instead of just using `lock_file_fd`?

Not really. No idea what I was thinking here, will fix.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.