Re: [PATCH v2 0/9] reftable: improvements and fixes for compaction
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Aug 8, 2024, 12:26 UTC
- Message-ID
- <CAOLa=ZR8D7LufbLnGiZC34UXdYtZgD1YPc6Mt4tvG4=t6OsLjQ@mail.gmail.com>
- In-Reply-To
- <cover.1722862822.git.ps@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 21 quoted lines
> Hi, > > this is the second version of my patch series that aims to improve the > way reftable stack perform compaction. > > Changes compared to v1: > > - Extract a test helper function that sets up a stack with N tables > containing refs. > > - Reuse file descriptor that we have already stored in a local > variable instead of calling `lock_file_fd()` a second time. > > - Remove a no-op change in the last patch. > > - Add a comment explaining why we have to allocate N+1 many table > names. > > - Some typo fixes. > > Thanks!
I haven't reviewed v1, but did skim through it. I left some comments, (maybe they were already asked/answered) overall the series looks great to me.
[snip]