Re: [PATCHv3] send-email: Ask if a patch should be sent twice

From: Dmitry Safonov <dima@arista.com>
Date: Jul 30, 2019, 21:19 UTC
Message-ID: <e12b1d56-717e-2b1e-8475-9353a855e343@arista.com>
In-Reply-To: <20190730211012.GS20404@szeder.dev>

On 7/30/19 10:10 PM, SZEDER Gábor wrote:

Show 23 quoted lines

> On Tue, Jul 30, 2019 at 09:33:27PM +0100, Dmitry Safonov wrote:
>> @@ -589,6 +591,19 @@ test_expect_success $PREREQ 'In-Reply-To with --chain-reply-to' '
>>  	test_cmp expect actual
>>  '
>>  
>> +test_expect_success $PREREQ 'ask confirmation for double-send' '
>> +	clean_fake_sendmail &&
>> +	echo y | \
>> +		GIT_SEND_EMAIL_NOTTY=1 \
>> +		git send-email --from=author@example.com \
>> +			--to=nobody@example.com \
>> +			--smtp-server="$(pwd)/fake.sendmail" \
>> +			--validate \
>> +			$patches $patches $patches \
>> +			>stdout &&
>> +	! test_i18ngrep "Patches specified several times: " stdout
> 
> You should write this as 'test_i18ngrep ! <...>'.  When running the
> test with GIT_TEST_GETTEXT_POISON=true, then 'test_i18ngrep' is
> basically a noop and always returns with success, the leading ! would
> turn that into a failure, which then would fail the test.
> 
> Sorry for not being specific enough.

No worries, thanks for the review anyway, quite educative - I haven't worked much on i18-related things in other projects, so sorry for not getting it straight away. Will resend shortly..

Thanks,
          Dmtiry