Re: [PATCHv3] send-email: Ask if a patch should be sent twice

From: Jeff King <peff@peff.net>
Date: Jul 31, 2019, 01:06 UTC
Message-ID: <20190731010625.GB9610@sigill.intra.peff.net>
In-Reply-To: <CANaxB-yygbxt=-sP+cyhR9WhcyEck+Wy=453huwfVNC9+So0BA@mail.gmail.com>

On Tue, Jul 30, 2019 at 03:56:43PM -0700, Andrey Vagin wrote:

Show 12 quoted lines

> On Tue, Jul 30, 2019 at 3:13 PM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > Dmitry Safonov <dima@arista.com> writes:
> >
> > > I was almost certain that git won't let me send the same patch twice,
> >
> > Why?  And more importantly, does it matter to readers of this
> > message what you thought?
> 
> Sounds rude. What matter to readers except author's thoughts? I guess you want
> to say that the comment should be in more neutral technical form without
> personal pronouns.

IMHO it's OK to use personal pronouns, but it's good to stick to the facts. It's easy to go off on a tangent about what led you to the patch that ends up making it harder for somebody reading the patch later to get to the point.

In this case, you did the leg-work to advance the story from "I'm confused about it should do..." to "it definitely does X now, and it would be better if it did Y". That's probably the best place for a later reader of the commit message to pick it up.

-Peff

PS I agree that what Junio wrote does sound a bit rude, but I don't
   think that was his intent. It's easy to accidentally be a little too
   curt during reviews (and I'm sure I've done it myself many times).
   Hopefully we can all take this as a reminder to be careful. :)