Re: [PATCHv3] send-email: Ask if a patch should be sent twice

From: Dmitry Safonov <dima@arista.com>
Date: Jul 30, 2019, 23:05 UTC
Message-ID: <5775af07-f425-8192-3f2b-a45f21981407@arista.com>
In-Reply-To: <xmqq5znjrx0h.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On 7/30/19 11:13 PM, Junio C Hamano wrote:

Show 6 quoted lines

> Dmitry Safonov <dima@arista.com> writes:
> 
>> I was almost certain that git won't let me send the same patch twice,
> 
> Why?  And more importantly, does it matter to readers of this
> message what you thought?

I see the point of putting description in impersonal, technical way. Probably, was irritated after sending 50 patches instead of 37. Also I've seen that in `git log | grep ' I '` over the project, not that it justifies using it in the discussed patch.

Show 13 quoted lines

> 
>> but today I've managed to double-send a directory by a mistake:
>> 	git send-email --to linux-kernel@vger.kernel.org /tmp/timens/
>> 	    --cc 'Dmitry Safonov <0x7f454c46@gmail.com>' /tmp/timens/`
>>
>> [I haven't noticed that I put the directory twice ^^]
>>
>> Prevent this shipwreck from happening again by asking if a patch
>> is sent multiple times on purpose.
>>
>> link: https://lkml.kernel.org/r/4d53ebc7-d5b2-346e-c383-606401d19d3a@gmail.com
> 
> What does "link:" mean?

It's a tag, usually used to point URL for more information. Maybe not that common in git-ml, but often it shows an example of what can go wrong without a patch.

Show 5 quoted lines

> 
>> Cc: Andrei Vagin <avagin@openvz.org>
> 
> What's the significance for this project to record that this patch
> was CCed to Andrei?

I've felt like I need to give credit to my friend with whom I was working on the patches set; which I've failed to send properly. Maybe it's a thing of more opensource-friendly communities like lkml.

Show 7 quoted lines

> 
>> Suggested-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> 
> I think "Helped-by:" is a lot more appropriate, viewing the exchange
> on v2 from the sideline.
> 
>> Signed-off-by: Dmitry Safonov <dima@arista.com>

To be honest, I don't feel like going on with v5. I've underestimate how welcoming some communities are to foreign patches.

If you feel like it's still worth to have the feature, please carry-on
with the tag
Abandoned-by: Dmitry Safonov <dima@arista.com>
and don't drop Cc tag.

[..]
Thanks and sorry for waisted time,
          Dmitry