[PATCH 1/2] t0302: check helper can handle empty credentials
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 30, 2017, 17:20 UTC
- Message-ID
- <e055913ec27fc3feb3f017747560f454f6817a0b.1509383993.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <cover.1509383993.git.johannes.schindelin@gmx.de>
From: =?UTF-8?q?Jakub=20Bere=C5=BCa=C5=84ski?= <kuba@berezanscy.pl>
Make sure the helper does not crash when blank username and password is provided. If the helper can save such credentials, it should be able to read them back.
Signed-off-by: Jakub Bereżański <kuba@berezanscy.pl> --- t/lib-credential.sh | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
diff --git a/t/lib-credential.sh b/t/lib-credential.sh index d8e41f7ddd1..937b831ea67 100755 --- a/t/lib-credential.sh +++ b/t/lib-credential.sh @@ -44,6 +44,7 @@ helper_test_clean() { reject $1 https example.com user2 reject $1 http path.tld user reject $1 https timeout.tld user + reject $1 https sso.tld } reject() { @@ -250,6 +251,24 @@ helper_test() { password=pass2 EOF ' + + test_expect_success "helper ($HELPER) can store empty username" ' + check approve $HELPER <<-\EOF && + protocol=https + host=sso.tld + username= + password= + EOF + check fill $HELPER <<-\EOF + protocol=https + host=sso.tld + -- + protocol=https + host=sso.tld + username= + password= + EOF + ' } helper_test_timeout() {
-- 2.15.0.windows.1