git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] wincred: learn to handle "empty credentials"

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 30, 2017, 17:20 UTC
Message-ID
<cover.1509383993.git.johannes.schindelin@gmx.de>

As we learned some time ago, NTLM authentication happens by passing "empty credentials", i.e. 0-length usernames and passwords.

However, when saved in the Windows Credential Manager, such usernames and passwords come back as null when reading the credential. Let's handle this.

This patch series is a tender four years old and has been simmering in Git for Windows since version v1.8.4, so it is most likely mature enough (even at that young age) to enter core Git.

Note: these days, Git for Windows prefers to use the Git Credential
Manager for Windows instead, but the wincred code is still carried in
Git's contrib/ and should be fixed there, too.
Jakub Bereżański (2):
  t0302: check helper can handle empty credentials
  wincred: handle empty username/password correctly
 contrib/credential/wincred/git-credential-wincred.c | 10 ++++++++--
 t/lib-credential.sh                                 | 19 +++++++++++++++++++
 2 files changed, 27 insertions(+), 2 deletions(-)
base-commit: cb5918aa0d50f50e83787f65c2ddc3dcb10159fe
Published-As: https://github.com/dscho/git/releases/tag/jberezanski/wincred-sso-r2-v1
Fetch-It-Via: git fetch https://github.com/dscho/git jberezanski/wincred-sso-r2-v1
-- 
2.15.0.windows.1
Next: Johannes Schindelin
Message 1 of 5 in “wincred: learn to handle "empty credentials"”
  1. 0/2 wincred: learn to handle "empty credentials"Johannes Schindelin, Oct 30, 2017
  2. 1/2 t0302: check helper can handle empty credentialsJohannes Schindelin, Oct 30, 2017
  3. Jeff KingOct 30, 2017
  4. Johannes SchindelinOct 31, 2017
  5. 2/2 wincred: handle empty username/password correctlyJohannes Schindelin, Oct 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.