git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t0302: check helper can handle empty credentials

From
Jeff King <peff@peff.net>
Date
Oct 30, 2017, 18:27 UTC
Message-ID
<20171030182718.oyzhjffd6jd4wslu@sigill.intra.peff.net>
In-Reply-To
<e055913ec27fc3feb3f017747560f454f6817a0b.1509383993.git.johannes.schindelin@gmx.de>
On Mon, Oct 30, 2017 at 06:20:12PM +0100, Johannes Schindelin wrote:
> Subject: Re: [PATCH 1/2] t0302: check helper can handle empty credentials

I guess we really care about t0303 here (which tests external helpers). This patch adds the test to lib-credential, so it hits the "cache" and "store" helpers, too. Which seems to pass, so I guess that's OK (I have to admit that as the author of those tools, I wasn't sure how they'd react).

> Make sure the helper does not crash when blank username and password is
> provided. If the helper can save such credentials, it should be able to
> read them back.

I worry that some third-party helpers might not be able to represent this case and would fail the test. This has been around for years no Windows, but probably hasn't ever been run with osxkeychain or libsecret. I'd be OK with taking this as-is, though, and waiting to see if anybody complains. At that point we'll know if the right solution is enhancing that helper, or providing a way to optionally skip this test.

(Though I have no idea if anybody actually runs t0303 against custom-built helpers in the first place. The process is pretty manual for now, though the Makefiles in contrib/credential could probably at least provide a "make test").

-Peff
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 3 of 5 in “wincred: learn to handle "empty credentials"”
  1. 0/2 wincred: learn to handle "empty credentials"Johannes Schindelin, Oct 30, 2017
  2. 1/2 t0302: check helper can handle empty credentialsJohannes Schindelin, Oct 30, 2017
  3. Jeff KingOct 30, 2017
  4. Johannes SchindelinOct 31, 2017
  5. 2/2 wincred: handle empty username/password correctlyJohannes Schindelin, Oct 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.