Re: t2400 on freebsd12

From: Jacob Abel <jacobabel@nullpo.dev>
Date: Jul 15, 2023, 03:02 UTC
Message-ID: <dk2fndv5aqshkgvfq55mrr5chdouenszedugyjoezcuatrsmn6@vqyih7nbqwbu>
In-Reply-To: <CAPig+cRMXJkrEgyVtC0u2QK=5QNnJOQnXBU_rE+JiGufEYH9sg@mail.gmail.com>

On 23/07/14 12:19PM, Eric Sunshine wrote:

Show 14 quoted lines

>
> [...]
> 
> I haven't been following this thread closely, but I wonder if the
> `grep` introduced by patch [3/8] of the cited patch series is
> problematic:
> 
>     grep -E "fatal:( options)? .* cannot be used together" actual
> 
> since BSD lineage regexp (including macOS) historically did not
> support the "?" repetition operator. Perhaps an easy fix would be to
> simplify this to:
> 
>     grep "cannot be used together" actual

Thank you for this insight. It didn't end up being exactly this issue but it seems to be a grep issue nonetheless. I've submitted a patch [1] which should resolve the issue (I tested it on a freebsd12 VM locally).

The TLDR of the issue is that grep 2.5 (GNU or BSD) doesn't seem to recognise `\s` (or its inverted counterpart) as ERE but newer GNU (and potentially other) grep versions do.

1. https://lore.kernel.org/git/20230715025512.7574-1-jacobabel@nullpo.dev/