Re: t2400 on freebsd12

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 16, 2023, 02:51 UTC
Message-ID: <CAPig+cRUOMSUzb95nnDPRnPN0TyDY93E4EdMp9zxTmnOfc8vKg@mail.gmail.com>
In-Reply-To: <dk2fndv5aqshkgvfq55mrr5chdouenszedugyjoezcuatrsmn6@vqyih7nbqwbu>

On Fri, Jul 14, 2023 at 11:02 PM Jacob Abel <jacobabel@nullpo.dev> wrote:

Show 15 quoted lines

> On 23/07/14 12:19PM, Eric Sunshine wrote:
> > I haven't been following this thread closely, but I wonder if the
> > `grep` introduced by patch [3/8] of the cited patch series is
> > problematic:
> >
> >     grep -E "fatal:( options)? .* cannot be used together" actual
>
> Thank you for this insight. It didn't end up being exactly this issue
> but it seems to be a grep issue nonetheless. I've submitted a
> patch [1] which should resolve the issue (I tested it on a freebsd12
> VM locally).
>
> The TLDR of the issue is that grep 2.5 (GNU or BSD) doesn't seem to
> recognise `\s` (or its inverted counterpart) as ERE but newer GNU (and
> potentially other) grep versions do.

That's great to hear. Thanks for digging into this and submitting a fix.

(The FreeBSD 12 VM I created with the idea of investigating this is now unnecessary.)