Re: t2400 on freebsd12

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 14, 2023, 16:19 UTC
Message-ID: <CAPig+cRMXJkrEgyVtC0u2QK=5QNnJOQnXBU_rE+JiGufEYH9sg@mail.gmail.com>
In-Reply-To: <356tacvizwbtwigdkz4byrrzsyjuktcb7cxaibf6wjocffgycp@iwhmszuuvzpl>

On Fri, Jul 14, 2023 at 2:30 AM Jacob Abel <jacobabel@nullpo.dev> wrote:

Show 18 quoted lines

> On 23/07/13 01:27PM, Junio C Hamano wrote:
> > "D. Ben Knoble" <ben.knoble@gmail.com> writes:
> > >> t2400-worktree-add.sh                            (Wstat: 256 Tests:
> > >> 227 Failed: 27)
> > >>   Failed tests:  50-52, 91-93, 107-109, 123-125, 139-141
> > >>                 159-161, 175-177, 191-193, 207-209
>>
> > I do not offhand know how well the FreeBSD port has been maintained,
> > or those who have (or had once in the past) stake in it are keeping
> > an eye on it.  Anybody?
>
> I wrote these tests[1]. All the tests that are failing are:
>
> - running `git worktree add` without `--orphan` or `--quiet`.
> - running in a repo with 1 local branch with a valid commit.
> - running in a worktree with an invalid/unborn HEAD.
>
> 1. https://lore.kernel.org/git/20230517214711.12467-1-jacobabel@nullpo.dev/

I haven't been following this thread closely, but I wonder if the `grep` introduced by patch [3/8] of the cited patch series is problematic:

    grep -E "fatal:( options)? .* cannot be used together" actual

since BSD lineage regexp (including macOS) historically did not support the "?" repetition operator. Perhaps an easy fix would be to simplify this to:

    grep "cannot be used together" actual