[PATCH v2 3/8] t4012: Actually quote the sed script
- From
Alexander Strasser <eclipse7@gmx.net>
- Date
- Jul 16, 2012, 20:43 UTC
- Message-ID
- <dac7fe6c66facf9bdecbe4764a7036ec3e6663fa.1342468069.git.eclipse7@gmx.net>
- In-Reply-To
- <cover.1342468069.git.eclipse7@gmx.net>
The nested quoting is not needed in this cases, thus the previous version did work just fine. Nevertheless the usage is misleading, so just achieve nested quoting by using double quotes instead. Lower the probability of breakage in the future and make the code easier to read.
NOTE: Just dropping the single quotes around the sed arguments would
have also been possible.Signed-off-by: Alexander Strasser <eclipse7@gmx.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/t4012-diff-binary.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh index 3c54269..60c2f6c 100755 --- a/t/t4012-diff-binary.sh +++ b/t/t4012-diff-binary.sh @@ -64,7 +64,7 @@ test_expect_success 'apply --numstat understands diff --binary format' ' # apply needs to be able to skip the binary material correctly # in order to report the line number of a corrupt patch. test_expect_success 'apply detecting corrupt patch correctly' ' - git diff | sed -e 's/-CIT/xCIT/' >broken && + git diff | sed -e "s/-CIT/xCIT/" >broken && if git apply --stat --summary broken 2>detected then echo unhappy - should have detected an error @@ -79,7 +79,7 @@ test_expect_success 'apply detecting corrupt patch correctly' ' ' test_expect_success 'apply detecting corrupt patch correctly' ' - git diff --binary | sed -e 's/-CIT/xCIT/' >broken && + git diff --binary | sed -e "s/-CIT/xCIT/" >broken && if git apply --stat --summary broken 2>detected then echo unhappy - should have detected an error
-- 1.7.10.2.552.gaa3bb87