git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 7/8] t4012: use 'printf' instead of 'dd' to generate a binary file

From
Alexander Strasser <eclipse7@gmx.net>
Date
Jul 16, 2012, 20:46 UTC
Message-ID
<d831ad4226688aa8ca2b3b152e242e357adbb3b2.1342468069.git.eclipse7@gmx.net>
In-Reply-To
<cover.1342468069.git.eclipse7@gmx.net>
From: Johannes Sixt <j6t@kdbg.org>

For some reason, 'echo X | dd bs=1k seek=1' creates a file with 2050 bytes on Windows instead of the expected 1026 bytes, so that a test fails. Since the actual contents of the file are irrelevant as long as there is at least one zero byte so that the diff machinery recognizes it as binary, use printf to generate it.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Alexander Strasser <eclipse7@gmx.net>
---
 t/t4012-diff-binary.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh
index 7b0e759..077870e 100755
--- a/t/t4012-diff-binary.sh
+++ b/t/t4012-diff-binary.sh
@@ -131,7 +131,7 @@ cat >expect <<EOF
 EOF
 
 test_expect_success 'diff --stat with binary files and big change count' '
-	echo X | dd of=binfile bs=1k seek=1 &&
+	printf "\01\00%1024d" 1 >binfile &&
 	git add binfile &&
 	i=0 &&
 	while test $i -lt 10000; do
-- 
1.7.10.2.552.gaa3bb87
Previous: Alexander StrasserNext: Alexander Strasser
Message 11 of 13 in “Cleaning up t4012”
  1. 0/6 Cleaning up t4012Alexander Strasser, Jul 11, 2012
  2. 7/6 t4012: use 'printf' instead of 'dd' to generate a binary fileJohannes Sixt, Jul 12, 2012
  3. Alexander StrasserJul 12, 2012
  4. 0/8 Cleaning up t4012Alexander Strasser, Jul 16, 2012
  5. 1/8 t4012: modernize style for quotingAlexander Strasser, Jul 16, 2012
  6. 2/8 t4012: Unquote git command fragment in test titleAlexander Strasser, Jul 16, 2012
  7. 3/8 t4012: Actually quote the sed scriptAlexander Strasser, Jul 16, 2012
  8. 4/8 t4012: Break up pipe into serial redirectionsAlexander Strasser, Jul 16, 2012
  9. 5/8 t4012: Make --shortstat test more robustAlexander Strasser, Jul 16, 2012
  10. 6/8 t4012: Re-indent test snippetsAlexander Strasser, Jul 16, 2012
  11. 7/8 t4012: use 'printf' instead of 'dd' to generate a binary fileAlexander Strasser, Jul 16, 2012
  12. 8/8 t4012: Use test_must_fail instead of if-elseAlexander Strasser, Jul 16, 2012
  13. Junio C HamanoJul 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.