git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 5/8] t4012: Make --shortstat test more robust

From
Alexander Strasser <eclipse7@gmx.net>
Date
Jul 16, 2012, 20:45 UTC
Message-ID
<4b210ed8738abd946521883ae14a885543d720da.1342468069.git.eclipse7@gmx.net>
In-Reply-To
<cover.1342468069.git.eclipse7@gmx.net>

The --shortstat test depends on the same scenario as the --stat test. Use the part of the same expected result for the --stat test to avoid duplicating it manually.

Signed-off-by: Alexander Strasser <eclipse7@gmx.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t4012-diff-binary.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh
index daf8234..4767761 100755
--- a/t/t4012-diff-binary.sh
+++ b/t/t4012-diff-binary.sh
@@ -38,9 +38,9 @@ test_expect_success 'apply --stat output for binary file change' '
 '
 
 test_expect_success 'diff --shortstat output for binary file change' '
-	echo " 4 files changed, 2 insertions(+), 2 deletions(-)" >expected &&
+	tail -n 1 expected >expect &&
 	git diff --shortstat >current &&
-	test_i18ncmp expected current
+	test_i18ncmp expect current
 '
 
 test_expect_success 'diff --shortstat output for binary file change only' '

-- 
1.7.10.2.552.gaa3bb87
Previous: Alexander StrasserNext: Alexander Strasser
Message 9 of 13 in “Cleaning up t4012”
  1. 0/6 Cleaning up t4012Alexander Strasser, Jul 11, 2012
  2. 7/6 t4012: use 'printf' instead of 'dd' to generate a binary fileJohannes Sixt, Jul 12, 2012
  3. Alexander StrasserJul 12, 2012
  4. 0/8 Cleaning up t4012Alexander Strasser, Jul 16, 2012
  5. 1/8 t4012: modernize style for quotingAlexander Strasser, Jul 16, 2012
  6. 2/8 t4012: Unquote git command fragment in test titleAlexander Strasser, Jul 16, 2012
  7. 3/8 t4012: Actually quote the sed scriptAlexander Strasser, Jul 16, 2012
  8. 4/8 t4012: Break up pipe into serial redirectionsAlexander Strasser, Jul 16, 2012
  9. 5/8 t4012: Make --shortstat test more robustAlexander Strasser, Jul 16, 2012
  10. 6/8 t4012: Re-indent test snippetsAlexander Strasser, Jul 16, 2012
  11. 7/8 t4012: use 'printf' instead of 'dd' to generate a binary fileAlexander Strasser, Jul 16, 2012
  12. 8/8 t4012: Use test_must_fail instead of if-elseAlexander Strasser, Jul 16, 2012
  13. Junio C HamanoJul 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.