git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 10/12] trace2/tr2_tls.h: remove unnecessary include

From
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Date
Dec 23, 2023, 17:14 UTC
Message-ID
<d9062fb11bea61febdd7721b03269a912488c80b.1703351701.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1617.v2.git.1703351700.gitgitgadget@gmail.com>
From: Elijah Newren <newren@gmail.com>

The unnecessary include in the header transitively pulled in some other headers actually needed by source files, though. Have those source files explicitly include the headers they need.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 trace2/tr2_tgt_normal.c | 1 +
 trace2/tr2_tls.c        | 1 +
 trace2/tr2_tls.h        | 1 -
 3 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/trace2/tr2_tgt_normal.c b/trace2/tr2_tgt_normal.c
index 38d5ebddf65..baef48aa698 100644
--- a/trace2/tr2_tgt_normal.c
+++ b/trace2/tr2_tgt_normal.c
@@ -2,6 +2,7 @@
 #include "config.h"
 #include "repository.h"
 #include "run-command.h"
+#include "strbuf.h"
 #include "quote.h"
 #include "version.h"
 #include "trace2/tr2_dst.h"
diff --git a/trace2/tr2_tls.c b/trace2/tr2_tls.c
index 601c9e5036f..4f75392952b 100644
--- a/trace2/tr2_tls.c
+++ b/trace2/tr2_tls.c
@@ -1,4 +1,5 @@
 #include "git-compat-util.h"
+#include "strbuf.h"
 #include "thread-utils.h"
 #include "trace.h"
 #include "trace2/tr2_tls.h"
diff --git a/trace2/tr2_tls.h b/trace2/tr2_tls.h
index f9049805d4d..3dfe6557fc4 100644
--- a/trace2/tr2_tls.h
+++ b/trace2/tr2_tls.h
@@ -1,7 +1,6 @@
 #ifndef TR2_TLS_H
 #define TR2_TLS_H
 
-#include "strbuf.h"
 #include "trace2/tr2_ctr.h"
 #include "trace2/tr2_tmr.h"
 
-- 
gitgitgadget
Previous: Elijah Newren via GitGitGadgetNext: Elijah Newren via GitGitGadget
Message 27 of 29 in “Additional header cleanups (removing unnecessary includes)”
  1. 00/12 Additional header cleanups (removing unnecessary includes)Elijah Newren via GitGitGadget, Dec 3, 2023
  2. 01/12 treewide: remove unnecessary includes from header filesElijah Newren via GitGitGadget, Dec 3, 2023
  3. 03/12 archive.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  4. 04/12 blame.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 3, 2023
  5. 02/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 3, 2023
  6. Junio C HamanoDec 3, 2023
  7. Junio C HamanoDec 20, 2023
  8. Elijah NewrenDec 20, 2023
  9. 05/12 fsmonitor--daemon.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 3, 2023
  10. 06/12 http.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  11. 07/12 line-log.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  12. 08/12 pkt-line.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  13. 09/12 submodule-config.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  14. 10/12 trace2/tr2_tls.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  15. 11/12 treewide: add direct includes currently only pulled in transitivelyElijah Newren via GitGitGadget, Dec 3, 2023
  16. 12/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 3, 2023
  17. 00/12 Additional header cleanups (removing unnecessary includes)Elijah Newren via GitGitGadget, Dec 23, 2023
  18. 01/12 treewide: remove unnecessary includes from header filesElijah Newren via GitGitGadget, Dec 23, 2023
  19. 03/12 archive.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  20. 02/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 23, 2023
  21. 04/12 blame.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 23, 2023
  22. 05/12 fsmonitor--daemon.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 23, 2023
  23. 06/12 http.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  24. 07/12 line-log.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  25. 08/12 pkt-line.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  26. 09/12 submodule-config.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  27. 10/12 trace2/tr2_tls.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  28. 11/12 treewide: add direct includes currently only pulled in transitivelyElijah Newren via GitGitGadget, Dec 23, 2023
  29. 12/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 23, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.