git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 02/12] treewide: remove unnecessary includes in source files

From
Elijah Newren <newren@gmail.com>
Date
Dec 20, 2023, 20:42 UTC
Message-ID
<CABPp-BF-ZN2RyXA6USNP5kubn1bJ76T-MwFfY7Tpf+x35aRdDA@mail.gmail.com>
In-Reply-To
<xmqqedfgsm6u.fsf@gitster.g>
On Wed, Dec 20, 2023 at 11:34 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 30 quoted lines
>
> Junio C Hamano <gitster@pobox.com> writes:
>
> > "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> >
> >> diff --git a/trace2.c b/trace2.c
> >> index 6dc74dff4c7..d4220af9ae1 100644
> >> --- a/trace2.c
> >> ...
> > An in-flight topic seem to want to see git_env_bool() that is
> > declared in parse.h that is pulled in via inclusion of config.h
> > hence this hunk breaks 'seen'.
> >
> >> diff --git a/t/helper/test-trace2.c b/t/helper/test-trace2.c
> >> index d5ca0046c89..a0032ee3964 100644
> >> --- a/t/helper/test-trace2.c
> >> ...
> > An in-flight topic starts using "struct key_value_info" that is
> > available via the inclusion of "config.h", hence this hunk breaks
> > the build of 'seen'.
>
> It seems that we have gained another topic in flight that gets
> broken by this change.  I can keep piling merge-fixes on top, but it
> does not look like a strategy that would scale well.
>
> Can we get this series thoroughly reviewed quickly to merge it down
> via 'next' to 'master' soonish, so that other topics can be rebased
> on the result, or is that too much to ask during the Winter lull?
>
> Thanks.

The Winter lull is my winter surge, so I can certainly quickly make whatever changes are required (well, assuming I can shake this fever...). But that doesn't help much with reviewing, since that should be done by someone other than the author. However, these particular type of changes are pretty innocuous; there's really not anything clever going on, it's just a lot of gruntwork, and does-it-compile is most of the review.

Anyway, I'll reroll, dropping or holding back any changes that conflict with next or seen, and see if that encourages anyone to chime in.

Previous: Junio C HamanoNext: Elijah Newren via GitGitGadget
Message 8 of 29 in “Additional header cleanups (removing unnecessary includes)”
  1. 00/12 Additional header cleanups (removing unnecessary includes)Elijah Newren via GitGitGadget, Dec 3, 2023
  2. 01/12 treewide: remove unnecessary includes from header filesElijah Newren via GitGitGadget, Dec 3, 2023
  3. 03/12 archive.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  4. 04/12 blame.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 3, 2023
  5. 02/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 3, 2023
  6. Junio C HamanoDec 3, 2023
  7. Junio C HamanoDec 20, 2023
  8. Elijah NewrenDec 20, 2023
  9. 05/12 fsmonitor--daemon.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 3, 2023
  10. 06/12 http.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  11. 07/12 line-log.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  12. 08/12 pkt-line.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  13. 09/12 submodule-config.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  14. 10/12 trace2/tr2_tls.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  15. 11/12 treewide: add direct includes currently only pulled in transitivelyElijah Newren via GitGitGadget, Dec 3, 2023
  16. 12/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 3, 2023
  17. 00/12 Additional header cleanups (removing unnecessary includes)Elijah Newren via GitGitGadget, Dec 23, 2023
  18. 01/12 treewide: remove unnecessary includes from header filesElijah Newren via GitGitGadget, Dec 23, 2023
  19. 03/12 archive.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  20. 02/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 23, 2023
  21. 04/12 blame.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 23, 2023
  22. 05/12 fsmonitor--daemon.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 23, 2023
  23. 06/12 http.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  24. 07/12 line-log.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  25. 08/12 pkt-line.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  26. 09/12 submodule-config.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  27. 10/12 trace2/tr2_tls.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  28. 11/12 treewide: add direct includes currently only pulled in transitivelyElijah Newren via GitGitGadget, Dec 23, 2023
  29. 12/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 23, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.