git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 09/12] submodule-config.h: remove unnecessary include

From
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Date
Dec 3, 2023, 06:41 UTC
Message-ID
<6d25811965cb55f7044e98ea020da2516664ad35.1701585683.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1617.git.1701585682.gitgitgadget@gmail.com>
From: Elijah Newren <newren@gmail.com>

The unnecessary include in the header transitively pulled in some other headers actually needed by source files, though. Have those source files explicitly include the headers they need.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 submodule-config.h        | 1 -
 t/helper/test-submodule.c | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/submodule-config.h b/submodule-config.h
index e8164cca3e4..958f320ac6c 100644
--- a/submodule-config.h
+++ b/submodule-config.h
@@ -3,7 +3,6 @@
 
 #include "config.h"
 #include "submodule.h"
-#include "strbuf.h"
 #include "tree-walk.h"
 
 /**
diff --git a/t/helper/test-submodule.c b/t/helper/test-submodule.c
index 356e0a26c5a..50c154d0370 100644
--- a/t/helper/test-submodule.c
+++ b/t/helper/test-submodule.c
@@ -4,6 +4,7 @@
 #include "remote.h"
 #include "repository.h"
 #include "setup.h"
+#include "strbuf.h"
 #include "submodule-config.h"
 #include "submodule.h"
 
-- 
gitgitgadget
Previous: Elijah Newren via GitGitGadgetNext: Elijah Newren via GitGitGadget
Message 13 of 29 in “Additional header cleanups (removing unnecessary includes)”
  1. 00/12 Additional header cleanups (removing unnecessary includes)Elijah Newren via GitGitGadget, Dec 3, 2023
  2. 01/12 treewide: remove unnecessary includes from header filesElijah Newren via GitGitGadget, Dec 3, 2023
  3. 03/12 archive.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  4. 04/12 blame.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 3, 2023
  5. 02/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 3, 2023
  6. Junio C HamanoDec 3, 2023
  7. Junio C HamanoDec 20, 2023
  8. Elijah NewrenDec 20, 2023
  9. 05/12 fsmonitor--daemon.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 3, 2023
  10. 06/12 http.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  11. 07/12 line-log.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  12. 08/12 pkt-line.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  13. 09/12 submodule-config.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  14. 10/12 trace2/tr2_tls.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 3, 2023
  15. 11/12 treewide: add direct includes currently only pulled in transitivelyElijah Newren via GitGitGadget, Dec 3, 2023
  16. 12/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 3, 2023
  17. 00/12 Additional header cleanups (removing unnecessary includes)Elijah Newren via GitGitGadget, Dec 23, 2023
  18. 01/12 treewide: remove unnecessary includes from header filesElijah Newren via GitGitGadget, Dec 23, 2023
  19. 03/12 archive.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  20. 02/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 23, 2023
  21. 04/12 blame.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 23, 2023
  22. 05/12 fsmonitor--daemon.h: remove unnecessary includesElijah Newren via GitGitGadget, Dec 23, 2023
  23. 06/12 http.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  24. 07/12 line-log.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  25. 08/12 pkt-line.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  26. 09/12 submodule-config.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  27. 10/12 trace2/tr2_tls.h: remove unnecessary includeElijah Newren via GitGitGadget, Dec 23, 2023
  28. 11/12 treewide: add direct includes currently only pulled in transitivelyElijah Newren via GitGitGadget, Dec 23, 2023
  29. 12/12 treewide: remove unnecessary includes in source filesElijah Newren via GitGitGadget, Dec 23, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.