git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] sha1-file: use OBJECT_INFO_NO_FETCH_IF_MISSING

From
Derrick Stolee <stolee@gmail.com>
Date
Jun 20, 2019, 12:39 UTC
Message-ID
<d88ac28b-638b-89c0-2bfb-634a0bb6ca4c@gmail.com>
In-Reply-To
<20190620085009.GC3952@sigill.intra.peff.net>
On 6/20/2019 4:50 AM, Jeff King wrote:
Show 13 quoted lines
> On Thu, Jun 20, 2019 at 10:30:26AM +0200, Christian Couder wrote:
> 
>> Currently the OBJECT_INFO_FOR_PREFETCH flag is used to check
>> if we should fetch objects from promisor remotes when we
>> haven't found them elsewhere.
>>
>> Now that OBJECT_INFO_NO_FETCH_IF_MISSING exists, let's use
>> it instead to be more correct in case this new flag is ever
>> used without OBJECT_INFO_QUICK.
> 
> I said earlier that this one would need to be tweaked for the new
> upstream name. But actually, I think it is not necessary after Stolee's
> patch.

Yes, I believe that 31f5256c82 does an equivalent thing to the combination of these patches.

Thanks, -Stolee

Previous: Jeff KingNext: Christian Couder
Message 6 of 10 in “Add OBJECT_INFO_NO_FETCH_IF_MISSING flag”
  1. 0/2 Add OBJECT_INFO_NO_FETCH_IF_MISSING flagChristian Couder, Jun 20, 2019
  2. 1/2 object-store: introduce OBJECT_INFO_NO_FETCH_IF_MISSINGChristian Couder, Jun 20, 2019
  3. Jeff KingJun 20, 2019
  4. 2/2 sha1-file: use OBJECT_INFO_NO_FETCH_IF_MISSINGChristian Couder, Jun 20, 2019
  5. Jeff KingJun 20, 2019
  6. Derrick StoleeJun 20, 2019
  7. Christian CouderJun 20, 2019
  8. Junio C HamanoJun 20, 2019
  9. Junio C HamanoJun 20, 2019
  10. Christian CouderJun 21, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.