git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] object-store: introduce OBJECT_INFO_NO_FETCH_IF_MISSING

From
Jeff King <peff@peff.net>
Date
Jun 20, 2019, 08:48 UTC
Message-ID
<20190620084842.GB3952@sigill.intra.peff.net>
In-Reply-To
<20190620083026.14524-2-chriscool@tuxfamily.org>
On Thu, Jun 20, 2019 at 10:30:25AM +0200, Christian Couder wrote:
Show 9 quoted lines
> The fetch_if_missing global variable should be replaced as much
> as possible by passing a flag to oid_object_info_extended().
> 
> The existing OBJECT_INFO_FOR_PREFETCH unfortunately conflates
> both a "no fetch if missing" meaning with OBJECT_INFO_QUICK
> which is about retrying packed storage.
> 
> Let's disambiguate that by adding a new explicit
> OBJECT_INFO_NO_FETCH_IF_MISSING flag.

I think this patch is obsoleted by Stolee's 31f5256c82 (sha1-file: split OBJECT_INFO_FOR_PREFETCH, 2019-05-28), which I think just made it to master in the last day or so.

There it's called OBJECT_INFO_SKIP_FETCH_OBJECT, so your 2/2 will need to be tweaked.

-Peff
Previous: Christian CouderNext: Christian Couder
Message 3 of 10 in “Add OBJECT_INFO_NO_FETCH_IF_MISSING flag”
  1. 0/2 Add OBJECT_INFO_NO_FETCH_IF_MISSING flagChristian Couder, Jun 20, 2019
  2. 1/2 object-store: introduce OBJECT_INFO_NO_FETCH_IF_MISSINGChristian Couder, Jun 20, 2019
  3. Jeff KingJun 20, 2019
  4. 2/2 sha1-file: use OBJECT_INFO_NO_FETCH_IF_MISSINGChristian Couder, Jun 20, 2019
  5. Jeff KingJun 20, 2019
  6. Derrick StoleeJun 20, 2019
  7. Christian CouderJun 20, 2019
  8. Junio C HamanoJun 20, 2019
  9. Junio C HamanoJun 20, 2019
  10. Christian CouderJun 21, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.