git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] sha1-file: use OBJECT_INFO_NO_FETCH_IF_MISSING

From
Christian Couder <christian.couder@gmail.com>
Date
Jun 20, 2019, 08:30 UTC
Message-ID
<20190620083026.14524-3-chriscool@tuxfamily.org>
In-Reply-To
<20190620083026.14524-1-chriscool@tuxfamily.org>

Currently the OBJECT_INFO_FOR_PREFETCH flag is used to check if we should fetch objects from promisor remotes when we haven't found them elsewhere.

Now that OBJECT_INFO_NO_FETCH_IF_MISSING exists, let's use it instead to be more correct in case this new flag is ever used without OBJECT_INFO_QUICK.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 sha1-file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sha1-file.c b/sha1-file.c
index ed5c50dac4..2116ff1e70 100644
--- a/sha1-file.c
+++ b/sha1-file.c
@@ -1379,7 +1379,7 @@ int oid_object_info_extended(struct repository *r, const struct object_id *oid,
 		/* Check if it is a missing object */
 		if (fetch_if_missing && repository_format_partial_clone &&
 		    !already_retried && r == the_repository &&
-		    !(flags & OBJECT_INFO_FOR_PREFETCH)) {
+		    !(flags & OBJECT_INFO_NO_FETCH_IF_MISSING)) {
 			/*
 			 * TODO Investigate having fetch_object() return
 			 * TODO error/success and stopping the music here.
-- 
2.22.0
Previous: Jeff KingNext: Jeff King
Message 4 of 10 in “Add OBJECT_INFO_NO_FETCH_IF_MISSING flag”
  1. 0/2 Add OBJECT_INFO_NO_FETCH_IF_MISSING flagChristian Couder, Jun 20, 2019
  2. 1/2 object-store: introduce OBJECT_INFO_NO_FETCH_IF_MISSINGChristian Couder, Jun 20, 2019
  3. Jeff KingJun 20, 2019
  4. 2/2 sha1-file: use OBJECT_INFO_NO_FETCH_IF_MISSINGChristian Couder, Jun 20, 2019
  5. Jeff KingJun 20, 2019
  6. Derrick StoleeJun 20, 2019
  7. Christian CouderJun 20, 2019
  8. Junio C HamanoJun 20, 2019
  9. Junio C HamanoJun 20, 2019
  10. Christian CouderJun 21, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.