git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] format-patch: avoid generation of empty patches

From
Nathan W. Panike <nathan.panike@gmail.com>
Date
Jan 10, 2009, 18:07 UTC
Message-ID
<d77df1110901101007o1d17142aub6971b72ba55c89e@mail.gmail.com>
In-Reply-To
<20090110161722.GA18859@myhost>
Hi:

On Sat, Jan 10, 2009 at 10:17 AM, Alexander Potashev <aspotashev@gmail.com> wrote:

...
> AFAIU get_revision stops revision iteration when it appears to stay at
> the root commit. So, if we will replace 'break' with 'continue', the
> 'while' loop will finish right after that 'continue'.
> However, I might be wrong... please, correct me then.

I was thinking of the case where there is more than one root. Maybe the code does the right thing then, but I confess I have not looked at it deeply enough to know.

Nathan Panike
Previous: Alexander PotashevNext: Junio C Hamano
Message 8 of 11 in “Get format-patch to show first commit after root commit”
  1. Get format-patch to show first commit after root commitNathan W. Panike, Jan 9, 2009
  2. Junio C HamanoJan 10, 2009
  3. Nathan W. PanikeJan 10, 2009
  4. Alexander PotashevJan 10, 2009
  5. format-patch: avoid generation of empty patchesAlexander Potashev, Jan 10, 2009
  6. Nathan W. PanikeJan 10, 2009
  7. Alexander PotashevJan 10, 2009
  8. Nathan W. PanikeJan 10, 2009
  9. Junio C HamanoJan 10, 2009
  10. Add new testcases for format-patch root commitsAlexander Potashev, Jan 10, 2009
  11. Alexander PotashevJan 10, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.