From: Nathan W. Panike <nathan.panike@gmail.com>
Date: Sat, 10 Jan 2009 18:07:06 GMT
Subject: Re: [PATCH] format-patch: avoid generation of empty patches
Message-ID: <d77df1110901101007o1d17142aub6971b72ba55c89e@mail.gmail.com>
In-Reply-To: <20090110161722.GA18859@myhost>

Hi:

On Sat, Jan 10, 2009 at 10:17 AM, Alexander Potashev
<aspotashev@gmail.com> wrote:

...

> AFAIU get_revision stops revision iteration when it appears to stay at
> the root commit. So, if we will replace 'break' with 'continue', the
> 'while' loop will finish right after that 'continue'.

> However, I might be wrong... please, correct me then.

I was thinking of the case where there is more than one root.  Maybe
the code does the right thing then, but I confess I have not looked at
it deeply enough to know.

Nathan Panike