git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] format-patch: avoid generation of empty patches

From
Nathan W. Panike <nathan.panike@gmail.com>
Date
Jan 10, 2009, 16:01 UTC
Message-ID
<d77df1110901100801s463bb43bt701a95df14f167d8@mail.gmail.com>
In-Reply-To
<20090110113903.GB25723@myhost>
Hi:

On Sat, Jan 10, 2009 at 5:39 AM, Alexander Potashev <aspotashev@gmail.com> wrote: ...

>
> +               if (!commit->parents && !rev.show_root_diff)
> +                       break;

Do you really want to stop getting commits? It seems like the break statement here should be a continue.

Nathan Panike
Previous: Alexander PotashevNext: Alexander Potashev
Message 6 of 11 in “Get format-patch to show first commit after root commit”
  1. Get format-patch to show first commit after root commitNathan W. Panike, Jan 9, 2009
  2. Junio C HamanoJan 10, 2009
  3. Nathan W. PanikeJan 10, 2009
  4. Alexander PotashevJan 10, 2009
  5. format-patch: avoid generation of empty patchesAlexander Potashev, Jan 10, 2009
  6. Nathan W. PanikeJan 10, 2009
  7. Alexander PotashevJan 10, 2009
  8. Nathan W. PanikeJan 10, 2009
  9. Junio C HamanoJan 10, 2009
  10. Add new testcases for format-patch root commitsAlexander Potashev, Jan 10, 2009
  11. Alexander PotashevJan 10, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.