From: Nathan W. Panike <nathan.panike@gmail.com>
Date: Sat, 10 Jan 2009 16:01:00 GMT
Subject: Re: [PATCH] format-patch: avoid generation of empty patches
Message-ID: <d77df1110901100801s463bb43bt701a95df14f167d8@mail.gmail.com>
In-Reply-To: <20090110113903.GB25723@myhost>

Hi:

On Sat, Jan 10, 2009 at 5:39 AM, Alexander Potashev
<aspotashev@gmail.com> wrote:
...
>
> +               if (!commit->parents && !rev.show_root_diff)
> +                       break;

Do you really want to stop getting commits?  It seems like the break
statement here should be a continue.

Nathan Panike