Re: [PATCH 0/5] Makefile: split up $(test_bindir_programs)

From: Derrick Stolee <derrickstolee@github.com>
Date: Sep 1, 2022, 15:02 UTC
Message-ID: <d6c46ce8-a4a5-f120-30d2-2388b6b63d7e@github.com>
In-Reply-To: <cover-0.5-00000000000-20220901T130817Z-avarab@gmail.com>

On 9/1/2022 9:17 AM, Ævar Arnfjörð Bjarmason wrote:

Show 9 quoted lines

> Ævar Arnfjörð Bjarmason (5):
>   Makefile: factor sed-powered '#!/bin/sh' munging into a variable
>   Makefile: define "TEST_{PROGRAM,OBJS}" variables earlier
>   Makefile: simplify $(test_bindir_programs) rule by splitting it up
>   Makefile: define bin-wrappers/% rules with a template
>   Makefile: fix "make clean && make bin-wrappers/$NAME" dependencies
> 
>  Makefile | 58 +++++++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 39 insertions(+), 19 deletions(-)

 
I find it very distracting when you send a full patch series in the
middle of someone else's patch series. Viewing the thread now involves
two distinct conversations, assuming that your series gets review and
requires multiple versions.

I would rather that you started a new thread with your proposed series and then sent a reply in this thread pointing to that one.

Thanks, -Stolee