Re: [PATCH v2 0/3] Makefile: fix issues with bin-wrappers/% rule

From: Jeff King <peff@peff.net>
Date: Oct 28, 2022, 00:57 UTC
Message-ID: <Y1so+kU1sZqYAS4y@coredump.intra.peff.net>
In-Reply-To: <cover-v2-0.3-00000000000-20221026T143533Z-avarab@gmail.com>

On Wed, Oct 26, 2022 at 04:42:34PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 6 quoted lines

> This simple topic fixes issues with the bin-wrappers/% rules, as seen
> in the range-diff below this never worked properly:
> 
> 	make bin-wrappers/git
> 
> I.e. we'd make the scirpt, but not "git".

Maybe I'm missing something, but the current behavior is what I'd expect to happen. Sure, bin-wrappers/git depends on "git" at run-time if you want it to do something useful. But AFAIK it doesn't at build-time. Why do we want a build-time dependency? Are we expecting rules to depend on bin-wrappers/foo but not also on foo? Or people to ask manually for those targets?

This kind of feels like making git-repack depend on git-pack-objects. One will call the other at run-time, but there's no reason the builds have to be together. And if you try to build and run one without building the other, well...if it hurts, don't do it.

-Peff