Re: [PATCH v2 0/9] scalar: integrate into core Git
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 5, 2022, 10:36 UTC
- Message-ID
- <73sr2o20-q1np-sn3n-n3p0-8s904n966344@tzk.qr>
- In-Reply-To
- <pull.1341.v2.git.1662134210.gitgitgadget@gmail.com>
Hi Victoria,
On Fri, 2 Sep 2022, Victoria Dye via GitGitGadget wrote:
Show 14 quoted lines
> Changes since V1 > ================ > > * Updated 'scalar.txt' description from "Associated with [git]" -> "Part of > [git]". > * Fixed Dscho's "Signed-off-by" and author emails on patches 3 & 4. > * Added 'scalar' to 'git help -a' command list. > * Removed translation tag for literal 'scalar help' usage string. > * Updated 'scalar clone' tests to clone to unique targets and clean up only > when test passes. > * Changed 'p9210' perf tests to invoke 'git' and 'scalar' with '-C', rather > than creating a subshell to run commands. > * Fixed use of 'test_env_bool' with 'GIT_PERF_USE_SCALAR', locally tested > to make sure it was working as-intended.
This iteration addresses all concerns I had.
Thank you so much! Dscho