Re: [PATCH v2 4/6] gitk: use more natural language for labels of color preferences

From: Johannes Sixt <j6t@kdbg.org>
Date: Aug 13, 2026, 19:35 UTC
Message-ID: <d6754ded-89f6-48e9-9755-24c45c90845f@kdbg.org>
In-Reply-To: <787b9472-d9ac-4d1f-814c-f7be9318ff55@gmail.com>

Am 13.08.26 um 19:00 schrieb Mark Levedahl:

Show 10 quoted lines

> On 8/12/26 9:16 AM, Johannes Sixt via GitGitGadget wrote:
>>          markbg      markbgcolor {} \
>> -                    [mc "Marked line bg"] \
>> +                    [mc "Marked line background"] \
>>                      [mc "marked line background"] \
>>
> 
> Not a new issue, but "marked line" is not a good description. What this actually controls
> is the background color of commit message text found by search criteria in the gui, not
> lines of text, and (as far as I can tell) never any text found in the patch text.

Actually, it is the background color of lines found via "Show origin of this line" in the diff panel.

When reading this code for the first time, I thought it has to do with the "Mark this commit" in the commit list, but it doesn't.

-- Hannes