Re: [PATCH 3/5] gitk: show color preferences on the button instead of the label

From: Johannes Sixt <j6t@kdbg.org>
Date: Aug 8, 2026, 09:33 UTC
Message-ID: <39f99016-8ac4-42f4-9a61-7f20b5431c1c@kdbg.org>
In-Reply-To: <eff19bf1-a8a8-4de0-9fc1-cea4b3d0f1a6@gmail.com>

Am 07.08.26 um 16:37 schrieb mark:

> But, the colored buttons do not stand out to my eye as much as in the prior approach.
> Perhaps use -borderwidth 2?

I agree. -borderwith 2 does help emphasize that these are clickable buttons. I'll also insert a small space between the buttons like this:

@@ -11868,9 +11868,9 @@ proc prefspage_colors {notebook} {
 
     foreach {uielem colorvar idx label title} $coloruielems {
         ttk::label $page.$uielem -text $label
-        button $page.${uielem}btn -padx 40 -pady 0 \
+        button $page.${uielem}btn -padx 40 -pady 0 -borderwidth 2 \
             -command [list choosecolor $colorvar $idx $page $title]
-        grid x $page.$uielem $page.${uielem}btn -sticky w
+        grid x $page.$uielem $page.${uielem}btn -sticky w -pady 1
     }
 
     grid columnconfigure $page 2 -weight 1


-- Hannes