Re: [PATCH 5/5] gitk: avoid constructing dialog titles from text pieces
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Aug 9, 2026, 07:27 UTC
- Message-ID
- <cf2a38fe-bd22-46fb-bb1d-f994c50f0a0b@kdbg.org>
- In-Reply-To
- <433a3e74-c66e-40a3-9971-c8cb9692967d@gmail.com>
Am 08.08.26 um 16:55 schrieb Mark Levedahl:
> The UI > already shows "new version" and "old version", so using new lines and old lines is consistent.
Exactly my reasoning as well!
Show 23 quoted lines
> But, one thing missing, hinted at by your suggestion "Background of ..." is that the clear > definition of what is being affected is poorly expressed. A complete description of each > item would require a paragraph, probably with an example image. Trying to compress into a > few words will always exploit context and presume some common language we expect a > git/gitk user to understand or be able to learn in context. > > Maybe some extra words and categorization would help. Consider using a longer category > description to provide common information, for instance: > > -General Canvas Area > Background > Marked Lines Background > Main Text > Selected Text > Link Text > -Commit Differences > old line text > new line text > -old line background > etc. > > etc, where the lines beginning with "-" are just separators and do not have an associated > color selection button.
I am not happy with additional section titles, because they take away vertical space. Actually, I think I'll *omit* "Diff" from the labels, because all colors apply to the primary panel of the entire UI, which is the diff text. Of course, the top ones listed above apply *also* to the other panels, but let's think about that another time.
My take-aways from your proposal are:
- The entries should be rearranged. In particular, selection, marked lines and link text must move above the diff colors.
- "old line text" and "old line background" are acceptable English phrases. (Note: singular "line", not plural "lines".)
-- Hannes