git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 00/14] Introduce clar testing framework

From
Pphillip.wood123@gmail.com <phillip.wood123@gmail.com>
Date
Sep 4, 2024, 14:32 UTC
Message-ID
<d5b1c95b-cbdc-4711-849e-c2cfc67787ee@gmail.com>
In-Reply-To
<cover.1725459142.git.ps@pks.im>
Hi Patrick
On 04/09/2024 15:16, Patrick Steinhardt wrote:
Show 7 quoted lines
> 
> Changes compared to v7:
> 
>    - Properly wire up the "--immediate" flag.
> 
>    - Give a hint for the syntax to run only specific suites or tests for
>      the "--run" and "--exclude" options.
As far as I'm concerned this version looks ready to be merged to next
Thanks
Phillip
Show 121 quoted lines
> Thanks!
> 
> Patrick
> 
> Johannes Schindelin (4):
>    clar: avoid compile error with mingw-w64
>    clar(win32): avoid compile error due to unused `fs_copy()`
>    clar: stop including `shellapi.h` unnecessarily
>    clar: add CMake support
> 
> Patrick Steinhardt (10):
>    t: do not pass GIT_TEST_OPTS to unit tests with prove
>    t: import the clar unit testing framework
>    t/clar: fix compatibility with NonStop
>    Makefile: fix sparse dependency on GENERATED_H
>    Makefile: make hdr-check depend on generated headers
>    Makefile: do not use sparse on third-party sources
>    Makefile: wire up the clar unit testing framework
>    t/unit-tests: implement test driver
>    t/unit-tests: convert strvec tests to use clar
>    t/unit-tests: convert ctype tests to use clar
> 
>   .gitignore                                 |   1 +
>   Documentation/technical/unit-tests.txt     |   2 +
>   Makefile                                   |  53 +-
>   contrib/buildsystems/CMakeLists.txt        |  53 ++
>   t/Makefile                                 |   4 +-
>   t/run-test.sh                              |   2 +-
>   t/unit-tests/.gitignore                    |   2 +
>   t/unit-tests/clar-generate.awk             |  50 ++
>   t/unit-tests/clar/.github/workflows/ci.yml |  23 +
>   t/unit-tests/clar/COPYING                  |  15 +
>   t/unit-tests/clar/README.md                | 329 ++++++++
>   t/unit-tests/clar/clar.c                   | 842 +++++++++++++++++++++
>   t/unit-tests/clar/clar.h                   | 173 +++++
>   t/unit-tests/clar/clar/fixtures.h          |  50 ++
>   t/unit-tests/clar/clar/fs.h                | 524 +++++++++++++
>   t/unit-tests/clar/clar/print.h             | 211 ++++++
>   t/unit-tests/clar/clar/sandbox.h           | 159 ++++
>   t/unit-tests/clar/clar/summary.h           | 143 ++++
>   t/unit-tests/clar/generate.py              | 266 +++++++
>   t/unit-tests/clar/test/.gitignore          |   4 +
>   t/unit-tests/clar/test/Makefile            |  39 +
>   t/unit-tests/clar/test/clar_test.h         |  16 +
>   t/unit-tests/clar/test/main.c              |  40 +
>   t/unit-tests/clar/test/main.c.sample       |  27 +
>   t/unit-tests/clar/test/resources/test/file |   1 +
>   t/unit-tests/clar/test/sample.c            |  84 ++
>   t/unit-tests/{t-ctype.c => ctype.c}        |  71 +-
>   t/unit-tests/strvec.c                      | 241 ++++++
>   t/unit-tests/t-strvec.c                    | 211 ------
>   t/unit-tests/unit-test.c                   |  47 ++
>   t/unit-tests/unit-test.h                   |  10 +
>   31 files changed, 3459 insertions(+), 234 deletions(-)
>   create mode 100644 t/unit-tests/clar-generate.awk
>   create mode 100644 t/unit-tests/clar/.github/workflows/ci.yml
>   create mode 100644 t/unit-tests/clar/COPYING
>   create mode 100644 t/unit-tests/clar/README.md
>   create mode 100644 t/unit-tests/clar/clar.c
>   create mode 100644 t/unit-tests/clar/clar.h
>   create mode 100644 t/unit-tests/clar/clar/fixtures.h
>   create mode 100644 t/unit-tests/clar/clar/fs.h
>   create mode 100644 t/unit-tests/clar/clar/print.h
>   create mode 100644 t/unit-tests/clar/clar/sandbox.h
>   create mode 100644 t/unit-tests/clar/clar/summary.h
>   create mode 100755 t/unit-tests/clar/generate.py
>   create mode 100644 t/unit-tests/clar/test/.gitignore
>   create mode 100644 t/unit-tests/clar/test/Makefile
>   create mode 100644 t/unit-tests/clar/test/clar_test.h
>   create mode 100644 t/unit-tests/clar/test/main.c
>   create mode 100644 t/unit-tests/clar/test/main.c.sample
>   create mode 100644 t/unit-tests/clar/test/resources/test/file
>   create mode 100644 t/unit-tests/clar/test/sample.c
>   rename t/unit-tests/{t-ctype.c => ctype.c} (68%)
>   create mode 100644 t/unit-tests/strvec.c
>   delete mode 100644 t/unit-tests/t-strvec.c
>   create mode 100644 t/unit-tests/unit-test.c
>   create mode 100644 t/unit-tests/unit-test.h
> 
> Range-diff against v7:
>   1:  b67f10ec0b0 =  1:  b67f10ec0b0 t: do not pass GIT_TEST_OPTS to unit tests with prove
>   2:  55a9b46e65f =  2:  55a9b46e65f t: import the clar unit testing framework
>   3:  f24401f0a87 =  3:  f24401f0a87 t/clar: fix compatibility with NonStop
>   4:  658a601c541 =  4:  658a601c541 clar: avoid compile error with mingw-w64
>   5:  0b8a6ac5fed =  5:  0b8a6ac5fed clar(win32): avoid compile error due to unused `fs_copy()`
>   6:  c50e7a0ea68 =  6:  c50e7a0ea68 clar: stop including `shellapi.h` unnecessarily
>   7:  b8f3f16dd27 =  7:  b8f3f16dd27 Makefile: fix sparse dependency on GENERATED_H
>   8:  3d3fe443b9a =  8:  3d3fe443b9a Makefile: make hdr-check depend on generated headers
>   9:  7d0f494850a =  9:  7d0f494850a Makefile: do not use sparse on third-party sources
> 10:  9c74c5ae019 = 10:  9c74c5ae019 Makefile: wire up the clar unit testing framework
> 11:  8bd5b3e2b29 ! 11:  81d932bfa33 t/unit-tests: implement test driver
>      @@ t/unit-tests/unit-test.c
>       +	struct string_list exclude_args = STRING_LIST_INIT_NODUP;
>       +	int immediate = 0;
>       +	struct option options[] = {
>      -+		OPT_BOOL('i', "--immediate", &immediate,
>      ++		OPT_BOOL('i', "immediate", &immediate,
>       +			 N_("immediately exit upon the first failed test")),
>      -+		OPT_STRING_LIST('r', "run", &run_args, N_("name"),
>      -+				N_("run only test suite or individual test <name>")),
>      -+		OPT_STRING_LIST('x', "exclude", &exclude_args, N_("name"),
>      -+				N_("exclude test suite <name>")),
>      ++		OPT_STRING_LIST('r', "run", &run_args, N_("suite[::test]"),
>      ++				N_("run only test suite or individual test <suite[::test]>")),
>      ++		OPT_STRING_LIST('x', "exclude", &exclude_args, N_("suite"),
>      ++				N_("exclude test suite <suite>")),
>       +		OPT_END(),
>       +	};
>       +	struct strvec args = STRVEC_INIT;
>      @@ t/unit-tests/unit-test.c
>       +
>       +	strvec_push(&args, argv[0]);
>       +	strvec_push(&args, "-t");
>      ++	if (immediate)
>      ++		strvec_push(&args, "-Q");
>       +	for (size_t i = 0; i < run_args.nr; i++)
>       +		strvec_pushf(&args, "-s%s", run_args.items[i].string);
>       +	for (size_t i = 0; i < exclude_args.nr; i++)
> 12:  3c3b9eacdfb = 12:  604303e31aa t/unit-tests: convert strvec tests to use clar
> 13:  c8360db2f86 = 13:  ba05b9f1eef t/unit-tests: convert ctype tests to use clar
> 14:  d51c146cd9d = 14:  8441d29daa8 clar: add CMake support
Previous: Patrick Steinhardt
Message 172 of 172 in “Introduce clar testing framework”
  1. 0/3 Introduce clar testing frameworkPatrick Steinhardt, Jul 31, 2024
  2. 1/3 t: import the clar unit testing frameworkPatrick Steinhardt, Jul 31, 2024
  3. Josh SteadmonJul 31, 2024
  4. Junio C HamanoJul 31, 2024
  5. Patrick SteinhardtAug 1, 2024
  6. rsbecker@nexbridge.comJul 31, 2024
  7. Patrick SteinhardtAug 1, 2024
  8. rsbecker@nexbridge.comAug 1, 2024
  9. rsbecker@nexbridge.comAug 1, 2024
  10. Patrick SteinhardtAug 1, 2024
  11. rsbecker@nexbridge.comAug 1, 2024
  12. Patrick SteinhardtAug 1, 2024
  13. rsbecker@nexbridge.comAug 1, 2024
  14. Patrick SteinhardtAug 1, 2024
  15. rsbecker@nexbridge.comAug 1, 2024
  16. Patrick SteinhardtAug 1, 2024
  17. rsbecker@nexbridge.comAug 1, 2024
  18. rsbecker@nexbridge.comAug 1, 2024
  19. rsbecker@nexbridge.comAug 1, 2024
  20. René ScharfeAug 1, 2024
  21. rsbecker@nexbridge.comAug 1, 2024
  22. 2/3 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Jul 31, 2024
  23. René ScharfeJul 31, 2024
  24. Patrick SteinhardtAug 1, 2024
  25. Junio C HamanoJul 31, 2024
  26. Junio C HamanoJul 31, 2024
  27. Patrick SteinhardtAug 1, 2024
  28. 3/3 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Jul 31, 2024
  29. Junio C HamanoJul 31, 2024
  30. rsbecker@nexbridge.comJul 31, 2024
  31. Junio C HamanoJul 31, 2024
  32. rsbecker@nexbridge.comJul 31, 2024
  33. rsbecker@nexbridge.comJul 31, 2024
  34. Patrick SteinhardtAug 1, 2024
  35. Patrick SteinhardtAug 1, 2024
  36. Josh SteadmonJul 31, 2024
  37. Patrick SteinhardtAug 1, 2024
  38. 0/7 Introduce clar testing frameworkPatrick Steinhardt, Aug 6, 2024
  39. 1/7 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Aug 6, 2024
  40. 2/7 t: import the clar unit testing frameworkPatrick Steinhardt, Aug 6, 2024
  41. Josh SteadmonAug 6, 2024
  42. Patrick SteinhardtAug 7, 2024
  43. 3/7 t/clar: fix whitespace errorsPatrick Steinhardt, Aug 6, 2024
  44. 4/7 t/clar: fix compatibility with NonStopPatrick Steinhardt, Aug 6, 2024
  45. 5/7 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Aug 6, 2024
  46. 6/7 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Aug 6, 2024
  47. Josh SteadmonAug 6, 2024
  48. Patrick SteinhardtAug 7, 2024
  49. 7/7 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Aug 6, 2024
  50. 0/7 Introduce clar testing frameworkPatrick Steinhardt, Aug 8, 2024
  51. 1/7 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Aug 8, 2024
  52. 2/7 t: import the clar unit testing frameworkPatrick Steinhardt, Aug 8, 2024
  53. 3/7 t/clar: fix whitespace errorsPatrick Steinhardt, Aug 8, 2024
  54. Junio C HamanoAug 13, 2024
  55. rsbecker@nexbridge.comAug 13, 2024
  56. Junio C HamanoAug 13, 2024
  57. rsbecker@nexbridge.comAug 13, 2024
  58. Junio C HamanoAug 13, 2024
  59. Patrick SteinhardtAug 14, 2024
  60. 4/7 t/clar: fix compatibility with NonStopPatrick Steinhardt, Aug 8, 2024
  61. 5/7 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Aug 8, 2024
  62. 6/7 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Aug 8, 2024
  63. 7/7 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Aug 8, 2024
  64. Josh SteadmonAug 12, 2024
  65. rsbecker@nexbridge.comAug 12, 2024
  66. Junio C HamanoAug 12, 2024
  67. rsbecker@nexbridge.comAug 12, 2024
  68. Junio C HamanoAug 12, 2024
  69. Patrick SteinhardtAug 13, 2024
  70. 0/7 Introduce clar testing frameworkPatrick Steinhardt, Aug 15, 2024
  71. 4/7 t/clar: fix compatibility with NonStopPatrick Steinhardt, Aug 15, 2024
  72. 7/7 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Aug 15, 2024
  73. 6/7 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Aug 15, 2024
  74. 2/7 t: import the clar unit testing frameworkPatrick Steinhardt, Aug 15, 2024
  75. 1/7 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Aug 15, 2024
  76. 3/7 t/clar: fix whitespace errorsPatrick Steinhardt, Aug 15, 2024
  77. 5/7 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Aug 15, 2024
  78. Junio C HamanoAug 15, 2024
  79. Patrick SteinhardtAug 16, 2024
  80. 0/9 Introduce clar testing frameworkPatrick Steinhardt, Aug 16, 2024
  81. 5/9 Makefile: make hdr-check depend on generated headersPatrick Steinhardt, Aug 16, 2024
  82. 4/9 Makefile: fix sparse dependency on GENERATED_HPatrick Steinhardt, Aug 16, 2024
  83. 1/9 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Aug 16, 2024
  84. 8/9 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Aug 16, 2024
  85. Phillip WoodAug 16, 2024
  86. Junio C HamanoAug 16, 2024
  87. Patrick SteinhardtAug 20, 2024
  88. 9/9 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Aug 16, 2024
  89. Phillip WoodAug 16, 2024
  90. Patrick SteinhardtAug 20, 2024
  91. Junio C HamanoAug 18, 2024
  92. 2/9 t: import the clar unit testing frameworkPatrick Steinhardt, Aug 16, 2024
  93. Phillip WoodAug 16, 2024
  94. Johannes SchindelinAug 23, 2024
  95. Phillip WoodAug 28, 2024
  96. Junio C HamanoAug 19, 2024
  97. rsbecker@nexbridge.comAug 19, 2024
  98. Junio C HamanoAug 19, 2024
  99. rsbecker@nexbridge.comAug 19, 2024
  100. Patrick SteinhardtAug 20, 2024
  101. 6/9 Makefile: do not use sparse on third-party sourcesPatrick Steinhardt, Aug 16, 2024
  102. 7/9 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Aug 16, 2024
  103. 3/9 t/clar: fix compatibility with NonStopPatrick Steinhardt, Aug 16, 2024
  104. Phillip WoodAug 16, 2024
  105. Patrick SteinhardtAug 20, 2024
  106. phillip.wood123@gmail.comAug 28, 2024
  107. 00/13 Introduce clar testing frameworkPatrick Steinhardt, Aug 20, 2024
  108. 01/13 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Aug 20, 2024
  109. 02/13 t: import the clar unit testing frameworkPatrick Steinhardt, Aug 20, 2024
  110. Phillip WoodAug 28, 2024
  111. Patrick SteinhardtSep 3, 2024
  112. 03/13 t/clar: fix compatibility with NonStopPatrick Steinhardt, Aug 20, 2024
  113. 04/13 clar: avoid compile error with mingw-w64Patrick Steinhardt, Aug 20, 2024
  114. 05/13 clar(win32): avoid compile error due to unused `fs_copy()`Patrick Steinhardt, Aug 20, 2024
  115. 06/13 clar: stop including `shellapi.h` unnecessarilyPatrick Steinhardt, Aug 20, 2024
  116. 07/13 Makefile: fix sparse dependency on GENERATED_HPatrick Steinhardt, Aug 20, 2024
  117. 08/13 Makefile: make hdr-check depend on generated headersPatrick Steinhardt, Aug 20, 2024
  118. 09/13 Makefile: do not use sparse on third-party sourcesPatrick Steinhardt, Aug 20, 2024
  119. 10/13 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Aug 20, 2024
  120. 11/13 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Aug 20, 2024
  121. Phillip WoodAug 28, 2024
  122. Patrick SteinhardtSep 3, 2024
  123. phillip.wood123@gmail.comSep 3, 2024
  124. Patrick SteinhardtSep 4, 2024
  125. phillip.wood123@gmail.comSep 4, 2024
  126. 12/13 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Aug 20, 2024
  127. Phillip WoodAug 28, 2024
  128. Patrick SteinhardtSep 3, 2024
  129. 13/13 clar: add CMake supportPatrick Steinhardt, Aug 20, 2024
  130. Phillip WoodAug 28, 2024
  131. Patrick SteinhardtAug 28, 2024
  132. phillip.wood123@gmail.comAug 28, 2024
  133. 00/14 Introduce clar testing frameworkPatrick Steinhardt, Sep 3, 2024
  134. 01/14 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Sep 3, 2024
  135. 02/14 t: import the clar unit testing frameworkPatrick Steinhardt, Sep 3, 2024
  136. Eric SunshineSep 3, 2024
  137. Patrick SteinhardtSep 4, 2024
  138. 03/14 t/clar: fix compatibility with NonStopPatrick Steinhardt, Sep 3, 2024
  139. 04/14 clar: avoid compile error with mingw-w64Patrick Steinhardt, Sep 3, 2024
  140. 05/14 clar(win32): avoid compile error due to unused `fs_copy()`Patrick Steinhardt, Sep 3, 2024
  141. 06/14 clar: stop including `shellapi.h` unnecessarilyPatrick Steinhardt, Sep 3, 2024
  142. 07/14 Makefile: fix sparse dependency on GENERATED_HPatrick Steinhardt, Sep 3, 2024
  143. 08/14 Makefile: make hdr-check depend on generated headersPatrick Steinhardt, Sep 3, 2024
  144. 09/14 Makefile: do not use sparse on third-party sourcesPatrick Steinhardt, Sep 3, 2024
  145. 10/14 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Sep 3, 2024
  146. 11/14 t/unit-tests: implement test driverPatrick Steinhardt, Sep 3, 2024
  147. Phillip WoodSep 4, 2024
  148. Patrick SteinhardtSep 4, 2024
  149. phillip.wood123@gmail.comSep 4, 2024
  150. 12/14 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Sep 3, 2024
  151. 13/14 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Sep 3, 2024
  152. 14/14 clar: add CMake supportPatrick Steinhardt, Sep 3, 2024
  153. Phillip WoodSep 4, 2024
  154. Patrick SteinhardtSep 4, 2024
  155. 00/14 Introduce clar testing frameworkPatrick Steinhardt, Sep 4, 2024
  156. 01/14 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Sep 4, 2024
  157. 02/14 t: import the clar unit testing frameworkPatrick Steinhardt, Sep 4, 2024
  158. 03/14 t/clar: fix compatibility with NonStopPatrick Steinhardt, Sep 4, 2024
  159. 04/14 clar: avoid compile error with mingw-w64Patrick Steinhardt, Sep 4, 2024
  160. 05/14 clar(win32): avoid compile error due to unused `fs_copy()`Patrick Steinhardt, Sep 4, 2024
  161. 06/14 clar: stop including `shellapi.h` unnecessarilyPatrick Steinhardt, Sep 4, 2024
  162. 07/14 Makefile: fix sparse dependency on GENERATED_HPatrick Steinhardt, Sep 4, 2024
  163. 08/14 Makefile: make hdr-check depend on generated headersPatrick Steinhardt, Sep 4, 2024
  164. 09/14 Makefile: do not use sparse on third-party sourcesPatrick Steinhardt, Sep 4, 2024
  165. 10/14 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Sep 4, 2024
  166. Junio C HamanoSep 9, 2024
  167. Patrick SteinhardtSep 10, 2024
  168. 11/14 t/unit-tests: implement test driverPatrick Steinhardt, Sep 4, 2024
  169. 12/14 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Sep 4, 2024
  170. 13/14 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Sep 4, 2024
  171. 14/14 clar: add CMake supportPatrick Steinhardt, Sep 4, 2024
  172. phillip.wood123@gmail.comSep 4, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.