Re: [RFC PATCH v2 6/7] t/unit-tests: convert strvec tests to use clar

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 7, 2024, 05:52 UTC
Message-ID: <ZrMLjjaz79s7O8B0@tanuki>
In-Reply-To: <6a6z3xduic3c6v27zeag5mxclupb4rc7a3gvoov5odpa7vqz4u@glpita3ojyxx>

On Tue, Aug 06, 2024 at 04:05:46PM -0700, Josh Steadmon wrote:

Show 14 quoted lines

> On 2024.08.06 16:14, Patrick Steinhardt wrote:
> > -static void t_static_init(void)
> > +void test_strvec__init(void)
> >  {
> >  	struct strvec vec = STRVEC_INIT;
> > -	check_pointer_eq(vec.v, empty_strvec);
> > -	check_uint(vec.nr, ==, 0);
> > -	check_uint(vec.alloc, ==, 0);
> > +	cl_assert_equal_p(vec.v, empty_strvec);
> > +	cl_assert(vec.nr == 0);
> > +	cl_assert(vec.alloc == 0);
> 
> Is there a reason you used cl_assert() instead of cl_assert_equal_i()
> for the .nr and .alloc checks here and below?

No, there isn't. Let me adapt these indeed, thanks!

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.