git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 08/14] Makefile: make hdr-check depend on generated headers

From
Patrick Steinhardt <ps@pks.im>
Date
Sep 4, 2024, 14:17 UTC
Message-ID
<3d3fe443b9a3f368287efa709cd744583da358e1.1725459142.git.ps@pks.im>
In-Reply-To
<cover.1725459142.git.ps@pks.im>

The "hdr-check" Makefile target compiles each of our headers as a standalone code unit to ensure that they are not missing any type declarations and can be included standalone.

With the next commit we will wire up the clar unit testing framework, which will have the effect that some headers start depending on generated ones. While we could declare that dependency explicitly, it does not really feel very maintainable in the future.

Instead, we do the same as in the preceding commit and have the objects depend on all of our generated headers. While again overly broad, it is easy to maintain and generating headers is not an expensive thing to do anyway.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index efd305ab358..8c4487dd0c6 100644
--- a/Makefile
+++ b/Makefile
@@ -3284,7 +3284,7 @@ HCC = $(HCO:hco=hcc)
 	@echo '#include "git-compat-util.h"' >$@
 	@echo '#include "$<"' >>$@
 
-$(HCO): %.hco: %.hcc FORCE
+$(HCO): %.hco: %.hcc $(GENERATED_H) FORCE
 	$(QUIET_HDR)$(CC) $(ALL_CFLAGS) -o /dev/null -c -xc $<
 
 .PHONY: hdr-check $(HCO)
-- 
2.46.0.519.g2e7b89e038.dirty
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 163 of 172 in “Introduce clar testing framework”
  1. 0/3 Introduce clar testing frameworkPatrick Steinhardt, Jul 31, 2024
  2. 1/3 t: import the clar unit testing frameworkPatrick Steinhardt, Jul 31, 2024
  3. Josh SteadmonJul 31, 2024
  4. Junio C HamanoJul 31, 2024
  5. Patrick SteinhardtAug 1, 2024
  6. rsbecker@nexbridge.comJul 31, 2024
  7. Patrick SteinhardtAug 1, 2024
  8. rsbecker@nexbridge.comAug 1, 2024
  9. rsbecker@nexbridge.comAug 1, 2024
  10. Patrick SteinhardtAug 1, 2024
  11. rsbecker@nexbridge.comAug 1, 2024
  12. Patrick SteinhardtAug 1, 2024
  13. rsbecker@nexbridge.comAug 1, 2024
  14. Patrick SteinhardtAug 1, 2024
  15. rsbecker@nexbridge.comAug 1, 2024
  16. Patrick SteinhardtAug 1, 2024
  17. rsbecker@nexbridge.comAug 1, 2024
  18. rsbecker@nexbridge.comAug 1, 2024
  19. rsbecker@nexbridge.comAug 1, 2024
  20. René ScharfeAug 1, 2024
  21. rsbecker@nexbridge.comAug 1, 2024
  22. 2/3 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Jul 31, 2024
  23. René ScharfeJul 31, 2024
  24. Patrick SteinhardtAug 1, 2024
  25. Junio C HamanoJul 31, 2024
  26. Junio C HamanoJul 31, 2024
  27. Patrick SteinhardtAug 1, 2024
  28. 3/3 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Jul 31, 2024
  29. Junio C HamanoJul 31, 2024
  30. rsbecker@nexbridge.comJul 31, 2024
  31. Junio C HamanoJul 31, 2024
  32. rsbecker@nexbridge.comJul 31, 2024
  33. rsbecker@nexbridge.comJul 31, 2024
  34. Patrick SteinhardtAug 1, 2024
  35. Patrick SteinhardtAug 1, 2024
  36. Josh SteadmonJul 31, 2024
  37. Patrick SteinhardtAug 1, 2024
  38. 0/7 Introduce clar testing frameworkPatrick Steinhardt, Aug 6, 2024
  39. 1/7 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Aug 6, 2024
  40. 2/7 t: import the clar unit testing frameworkPatrick Steinhardt, Aug 6, 2024
  41. Josh SteadmonAug 6, 2024
  42. Patrick SteinhardtAug 7, 2024
  43. 3/7 t/clar: fix whitespace errorsPatrick Steinhardt, Aug 6, 2024
  44. 4/7 t/clar: fix compatibility with NonStopPatrick Steinhardt, Aug 6, 2024
  45. 5/7 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Aug 6, 2024
  46. 6/7 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Aug 6, 2024
  47. Josh SteadmonAug 6, 2024
  48. Patrick SteinhardtAug 7, 2024
  49. 7/7 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Aug 6, 2024
  50. 0/7 Introduce clar testing frameworkPatrick Steinhardt, Aug 8, 2024
  51. 1/7 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Aug 8, 2024
  52. 2/7 t: import the clar unit testing frameworkPatrick Steinhardt, Aug 8, 2024
  53. 3/7 t/clar: fix whitespace errorsPatrick Steinhardt, Aug 8, 2024
  54. Junio C HamanoAug 13, 2024
  55. rsbecker@nexbridge.comAug 13, 2024
  56. Junio C HamanoAug 13, 2024
  57. rsbecker@nexbridge.comAug 13, 2024
  58. Junio C HamanoAug 13, 2024
  59. Patrick SteinhardtAug 14, 2024
  60. 4/7 t/clar: fix compatibility with NonStopPatrick Steinhardt, Aug 8, 2024
  61. 5/7 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Aug 8, 2024
  62. 6/7 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Aug 8, 2024
  63. 7/7 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Aug 8, 2024
  64. Josh SteadmonAug 12, 2024
  65. rsbecker@nexbridge.comAug 12, 2024
  66. Junio C HamanoAug 12, 2024
  67. rsbecker@nexbridge.comAug 12, 2024
  68. Junio C HamanoAug 12, 2024
  69. Patrick SteinhardtAug 13, 2024
  70. 0/7 Introduce clar testing frameworkPatrick Steinhardt, Aug 15, 2024
  71. 4/7 t/clar: fix compatibility with NonStopPatrick Steinhardt, Aug 15, 2024
  72. 7/7 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Aug 15, 2024
  73. 6/7 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Aug 15, 2024
  74. 2/7 t: import the clar unit testing frameworkPatrick Steinhardt, Aug 15, 2024
  75. 1/7 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Aug 15, 2024
  76. 3/7 t/clar: fix whitespace errorsPatrick Steinhardt, Aug 15, 2024
  77. 5/7 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Aug 15, 2024
  78. Junio C HamanoAug 15, 2024
  79. Patrick SteinhardtAug 16, 2024
  80. 0/9 Introduce clar testing frameworkPatrick Steinhardt, Aug 16, 2024
  81. 5/9 Makefile: make hdr-check depend on generated headersPatrick Steinhardt, Aug 16, 2024
  82. 4/9 Makefile: fix sparse dependency on GENERATED_HPatrick Steinhardt, Aug 16, 2024
  83. 1/9 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Aug 16, 2024
  84. 8/9 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Aug 16, 2024
  85. Phillip WoodAug 16, 2024
  86. Junio C HamanoAug 16, 2024
  87. Patrick SteinhardtAug 20, 2024
  88. 9/9 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Aug 16, 2024
  89. Phillip WoodAug 16, 2024
  90. Patrick SteinhardtAug 20, 2024
  91. Junio C HamanoAug 18, 2024
  92. 2/9 t: import the clar unit testing frameworkPatrick Steinhardt, Aug 16, 2024
  93. Phillip WoodAug 16, 2024
  94. Johannes SchindelinAug 23, 2024
  95. Phillip WoodAug 28, 2024
  96. Junio C HamanoAug 19, 2024
  97. rsbecker@nexbridge.comAug 19, 2024
  98. Junio C HamanoAug 19, 2024
  99. rsbecker@nexbridge.comAug 19, 2024
  100. Patrick SteinhardtAug 20, 2024
  101. 6/9 Makefile: do not use sparse on third-party sourcesPatrick Steinhardt, Aug 16, 2024
  102. 7/9 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Aug 16, 2024
  103. 3/9 t/clar: fix compatibility with NonStopPatrick Steinhardt, Aug 16, 2024
  104. Phillip WoodAug 16, 2024
  105. Patrick SteinhardtAug 20, 2024
  106. phillip.wood123@gmail.comAug 28, 2024
  107. 00/13 Introduce clar testing frameworkPatrick Steinhardt, Aug 20, 2024
  108. 01/13 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Aug 20, 2024
  109. 02/13 t: import the clar unit testing frameworkPatrick Steinhardt, Aug 20, 2024
  110. Phillip WoodAug 28, 2024
  111. Patrick SteinhardtSep 3, 2024
  112. 03/13 t/clar: fix compatibility with NonStopPatrick Steinhardt, Aug 20, 2024
  113. 04/13 clar: avoid compile error with mingw-w64Patrick Steinhardt, Aug 20, 2024
  114. 05/13 clar(win32): avoid compile error due to unused `fs_copy()`Patrick Steinhardt, Aug 20, 2024
  115. 06/13 clar: stop including `shellapi.h` unnecessarilyPatrick Steinhardt, Aug 20, 2024
  116. 07/13 Makefile: fix sparse dependency on GENERATED_HPatrick Steinhardt, Aug 20, 2024
  117. 08/13 Makefile: make hdr-check depend on generated headersPatrick Steinhardt, Aug 20, 2024
  118. 09/13 Makefile: do not use sparse on third-party sourcesPatrick Steinhardt, Aug 20, 2024
  119. 10/13 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Aug 20, 2024
  120. 11/13 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Aug 20, 2024
  121. Phillip WoodAug 28, 2024
  122. Patrick SteinhardtSep 3, 2024
  123. phillip.wood123@gmail.comSep 3, 2024
  124. Patrick SteinhardtSep 4, 2024
  125. phillip.wood123@gmail.comSep 4, 2024
  126. 12/13 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Aug 20, 2024
  127. Phillip WoodAug 28, 2024
  128. Patrick SteinhardtSep 3, 2024
  129. 13/13 clar: add CMake supportPatrick Steinhardt, Aug 20, 2024
  130. Phillip WoodAug 28, 2024
  131. Patrick SteinhardtAug 28, 2024
  132. phillip.wood123@gmail.comAug 28, 2024
  133. 00/14 Introduce clar testing frameworkPatrick Steinhardt, Sep 3, 2024
  134. 01/14 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Sep 3, 2024
  135. 02/14 t: import the clar unit testing frameworkPatrick Steinhardt, Sep 3, 2024
  136. Eric SunshineSep 3, 2024
  137. Patrick SteinhardtSep 4, 2024
  138. 03/14 t/clar: fix compatibility with NonStopPatrick Steinhardt, Sep 3, 2024
  139. 04/14 clar: avoid compile error with mingw-w64Patrick Steinhardt, Sep 3, 2024
  140. 05/14 clar(win32): avoid compile error due to unused `fs_copy()`Patrick Steinhardt, Sep 3, 2024
  141. 06/14 clar: stop including `shellapi.h` unnecessarilyPatrick Steinhardt, Sep 3, 2024
  142. 07/14 Makefile: fix sparse dependency on GENERATED_HPatrick Steinhardt, Sep 3, 2024
  143. 08/14 Makefile: make hdr-check depend on generated headersPatrick Steinhardt, Sep 3, 2024
  144. 09/14 Makefile: do not use sparse on third-party sourcesPatrick Steinhardt, Sep 3, 2024
  145. 10/14 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Sep 3, 2024
  146. 11/14 t/unit-tests: implement test driverPatrick Steinhardt, Sep 3, 2024
  147. Phillip WoodSep 4, 2024
  148. Patrick SteinhardtSep 4, 2024
  149. phillip.wood123@gmail.comSep 4, 2024
  150. 12/14 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Sep 3, 2024
  151. 13/14 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Sep 3, 2024
  152. 14/14 clar: add CMake supportPatrick Steinhardt, Sep 3, 2024
  153. Phillip WoodSep 4, 2024
  154. Patrick SteinhardtSep 4, 2024
  155. 00/14 Introduce clar testing frameworkPatrick Steinhardt, Sep 4, 2024
  156. 01/14 t: do not pass GIT_TEST_OPTS to unit tests with provePatrick Steinhardt, Sep 4, 2024
  157. 02/14 t: import the clar unit testing frameworkPatrick Steinhardt, Sep 4, 2024
  158. 03/14 t/clar: fix compatibility with NonStopPatrick Steinhardt, Sep 4, 2024
  159. 04/14 clar: avoid compile error with mingw-w64Patrick Steinhardt, Sep 4, 2024
  160. 05/14 clar(win32): avoid compile error due to unused `fs_copy()`Patrick Steinhardt, Sep 4, 2024
  161. 06/14 clar: stop including `shellapi.h` unnecessarilyPatrick Steinhardt, Sep 4, 2024
  162. 07/14 Makefile: fix sparse dependency on GENERATED_HPatrick Steinhardt, Sep 4, 2024
  163. 08/14 Makefile: make hdr-check depend on generated headersPatrick Steinhardt, Sep 4, 2024
  164. 09/14 Makefile: do not use sparse on third-party sourcesPatrick Steinhardt, Sep 4, 2024
  165. 10/14 Makefile: wire up the clar unit testing frameworkPatrick Steinhardt, Sep 4, 2024
  166. Junio C HamanoSep 9, 2024
  167. Patrick SteinhardtSep 10, 2024
  168. 11/14 t/unit-tests: implement test driverPatrick Steinhardt, Sep 4, 2024
  169. 12/14 t/unit-tests: convert strvec tests to use clarPatrick Steinhardt, Sep 4, 2024
  170. 13/14 t/unit-tests: convert ctype tests to use clarPatrick Steinhardt, Sep 4, 2024
  171. 14/14 clar: add CMake supportPatrick Steinhardt, Sep 4, 2024
  172. phillip.wood123@gmail.comSep 4, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.