Re: [PATCH 5/7] t3437: fix indendation of the here-doc
Hi Chariv and Eric
On 07/02/2021 18:54, Eric Sunshine wrote:
Show 21 quoted lines
> On Sun, Feb 7, 2021 at 1:19 PM Charvi Mendiratta <charvi077@gmail.com> wrote:
>> In the test scripts, the here-doc body and EOF are indented the same
>> amount as the command which opened the here-doc. Let's remove
>> one level of indendation.
>
> s/indendation/indentation/
>
> I found "In the test scripts" ambiguous. It isn't clear if you are
> talking about all test scripts or the script(s) this patch is fixing
> up. Sp, if you happen to re-roll for some reason, perhaps clarify by
> saying something like:
>
> The most common way to format here-docs in Git test scripts is for
> the body and EOF to be indented the same amount as the command
> which opened the here-doc. Fix a few here-docs in this script to
> conform to that standard.
>
>> Original-patch-by: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> I don't think this new patch is based upon Phillip's, so you can
> probably drop this attribution.
Good point - well spotted as ever Eric
Thanks
Phillip
>> Signed-off-by: Charvi Mendiratta <charvi077@gmail.com>