Re: [PATCH 3/7] rebase -i: clarify and fix 'fixup -c' rebase-todo help
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Feb 7, 2021, 18:49 UTC
- Message-ID
- <CAPig+cS-QK7dZ63NfEY8S2z+wveY43dHkQWV3krNDP_dYSfyJw@mail.gmail.com>
- In-Reply-To
- <20210207181439.1178-4-charvi077@gmail.com>
On Sun, Feb 7, 2021 at 1:19 PM Charvi Mendiratta <charvi077@gmail.com> wrote:
Show 5 quoted lines
> When `-c` says "edit the commit message" it's not clear what will be > edited. The original's commit message or the replacement's message or a > combination of the two. Word it such that it states more precisely what > exactly will be edited and also remove the use of a period and > capitalized word in the to-do help text.
If you happen to re-roll for some reason, it might be a good idea to explain why you are removing the period and capitalization since the reason is not otherwise clear to the casual reader. So, perhaps:
... exactly will be edited. While at it, also drop the jarring
period and capitalization, neither of which is otherwise present
in the message.or something like that.
> Signed-off-by: Charvi Mendiratta <charvi077@gmail.com>