Re: [PATCH 0/7][Outreachy] Improve the 'fixup [-C | -c]' in interactive rebase
- From
Charvi Mendiratta <charvi077@gmail.com>
- Date
- Feb 8, 2021, 04:31 UTC
- Message-ID
- <CAPSFM5fG1jSUM1tuw8UCzkLigpM9SqVqDO=wA1CQ_fs5Xy+04w@mail.gmail.com>
- In-Reply-To
- <CAPig+cTQaP_FvixPiwosPybxy-C91pvV_FvQfwf7cO0QGpH7UQ@mail.gmail.com>
On Mon, 8 Feb 2021 at 00:28, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 13 quoted lines
> > On Sun, Feb 7, 2021 at 1:18 PM Charvi Mendiratta <charvi077@gmail.com> wrote: > > This patch series is build on the top of "cm/rebase-i" in the 'next' branch and > > improves it. It fixup the source code of 'fixup [-C | -c]' command in the > > sequencer, do some fixes in rebase -i, improves the 'fixup_-C' like commands > > in lib-rebase.sh, update the test-script 't3437' and fixes a typo in the > > documentation. > > Thanks for working on this. I looked over the entire series and left a > few minor comments. As mentioned in my [6/7] review, you might also > want to consider splitting that patch into several patches (though > it's not clear if the extra work of doing so is warranted). Anyhow, > aside from some botched indentation in [6/7], it all looked clean.
Thanks for the corrections. I admit there are few silly mistakes, will fixup all and also split [6/7] in the next version.
Thanks and Regards, Charvi