git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] maintenance: handle geometric repack tasks with promisor pack(s)

From
Taylor Blau <ttaylorr@openai.com>
Date
Aug 5, 2026, 03:57 UTC
Message-ID
<cover.1785902237.git.ttaylorr@openai.com>

The geometric-repack maintenance task predates support for keeping promisor packs in their own geometric progression. After that support was added in dcc9c7ef47 (builtin/repack: handle promisor packs with geometric repacking, 2026-01-05), the maintenance task still made two decisions from the ordinary-pack progression alone:

 - whether an explicit run should use `--geometric` or its
   all-into-one fallback; and
 - whether `--auto` sees enough work to run the task at all.

That can make partial clones rewrite more than necessary. If the ordinary packs would all be rolled up, the task can choose the all-into-one path even when the promisor progression would leave a large pack alone. Likewise, an all-promisor repository can have a promisor rollup ready while `--auto` sees neither an ordinary split nor enough loose objects and skips the task.

The first patch makes the repack-mode choice consider both progressions. It keeps the all-into-one fallback only when neither progression leaves a pack above its split, so the fallback does not rewrite packs that geometric repack would have kept.

The second patch makes the `--auto` condition consider `geometry.promisor_split` alongside `geometry.split`. A non-zero split on either side means that geometric repack can combine at least two packs.

Both tests build three promisor packs whose object counts cause the two smaller packs to roll up while leaving the large pack intact. The `--auto` test uses a high loose-object threshold, so the promisor split is the only reason the task runs.

Thanks in advance for your review!
Taylor Blau (2):
  maintenance: account for promisor pack geometry
  maintenance: trigger --auto for promisor rollups
 builtin/gc.c                  |  5 +--
 t/t5331-pack-objects-stdin.sh |  3 +-
 t/t7900-maintenance.sh        | 68 +++++++++++++++++++++++++++++++++++
 3 files changed, 73 insertions(+), 3 deletions(-)
base-commit: a97fcc37c2bc6340a8d7ce78dedf227aac4e9aa7
-- 
2.55.0.483.gdc2fffc37c
Next: Taylor Blau
Message 1 of 10 in “maintenance: handle geometric repack tasks with promisor pack(s)”
  1. 0/2 maintenance: handle geometric repack tasks with promisor pack(s)Taylor Blau, Aug 5, 2026
  2. 1/2 maintenance: account for promisor pack geometryTaylor Blau, Aug 5, 2026
  3. Patrick SteinhardtAug 10, 2026
  4. Taylor BlauAug 10, 2026
  5. Patrick SteinhardtAug 11, 2026
  6. Taylor BlauAug 11, 2026
  7. Patrick SteinhardtAug 11, 2026
  8. 2/2 maintenance: trigger --auto for promisor rollupsTaylor Blau, Aug 5, 2026
  9. Patrick SteinhardtAug 10, 2026
  10. Taylor BlauAug 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.