git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] maintenance: account for promisor pack geometry

From
Patrick Steinhardt <ps@pks.im>
Date
Aug 11, 2026, 16:18 UTC
Message-ID
<antLRFfKMtSLaqdy@pks.im>
In-Reply-To
<antEnTVfHFEGQQZ_@com-79390>
On Tue, Aug 11, 2026 at 10:49:49AM -0500, Taylor Blau wrote:
Show 26 quoted lines
> On Tue, Aug 11, 2026 at 12:01:23PM +0200, Patrick Steinhardt wrote:
> > > So I am not sure that I understand your concern here, but please let me
> > > know if I am missing some aspect of it.
> >
> > The concern is that it's quite unlikely that both the geometric and
> > non-geometric sequence will merge all packs together at the same point
> > in time. Consequently, we'll never hit the case where we perform an
> > all-into-one pack to prune unreachable objects, and that may cause us to
> > never prune objects at all.
> >
> > So what I'm wondering is whether we should be a bit more clever about
> > that and perform an all-into-one repack under a new condition, like for
> > example when the objects we're about to repack exceed a certain
> > percentage of the repository size.
> >
> > Hope that clarifies it a bit :)
> 
> Ah, I see what you're saying. We should still be OK here as the goal of
> geometric repacking is to converge both the promisor and non-promisor
> packs towards a single pack, at which point we would do an all-into-one
> repack.
> 
> If the two are perfectly out of phase, then this change would prevent us
> from running all-into-one maintenance. But that does not seem like a
> likely scenario, and the behavior here should be a strict improvement in
> the meantime otherwise.

Yeah, I tend to agree. It's heuristics anyway, and from my point of view it's something that we can iterate on going forward.

Thanks!
Patrick
Previous: Taylor BlauNext: Taylor Blau
Message 7 of 10 in “maintenance: handle geometric repack tasks with promisor pack(s)”
  1. 0/2 maintenance: handle geometric repack tasks with promisor pack(s)Taylor Blau, Aug 5, 2026
  2. 1/2 maintenance: account for promisor pack geometryTaylor Blau, Aug 5, 2026
  3. Patrick SteinhardtAug 10, 2026
  4. Taylor BlauAug 10, 2026
  5. Patrick SteinhardtAug 11, 2026
  6. Taylor BlauAug 11, 2026
  7. Patrick SteinhardtAug 11, 2026
  8. 2/2 maintenance: trigger --auto for promisor rollupsTaylor Blau, Aug 5, 2026
  9. Patrick SteinhardtAug 10, 2026
  10. Taylor BlauAug 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.