git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] maintenance: account for promisor pack geometry

From
Patrick Steinhardt <ps@pks.im>
Date
Aug 10, 2026, 15:11 UTC
Message-ID
<annqJGFJPviEyfEC@pks.im>
In-Reply-To
<a9de123b43efb58c53c99c71eb7e34f29e075071.1785902237.git.ttaylorr@openai.com>
On Tue, Aug 04, 2026 at 08:57:40PM -0700, Taylor Blau wrote:
Show 23 quoted lines
> Commit 9bc151850c (builtin/maintenance: introduce
> "geometric-repack" task, 2025-10-24) added a new maintenance task to
> perform either a geometric repack, or an all-into-one repack if the
> geometric repack would itself produce a single pack.
> 
> Some time later, commit dcc9c7ef47 (builtin/repack: handle promisor
> packs with geometric repacking, 2026-01-05) taught the geometric
> repacking machinery to separate promisor packs from ordinary ones, but
> did not update the maintenance task accordingly.
> 
> As a consequence, the geometric-repack maintenance task only considers
> the non-promisor pack progression. It falls back to all-into-one
> whenever a geometric repack would roll up all non-promisor packs into a
> single pack, even if the promisor progression would keep a large pack
> and roll up only smaller ones.
> 
> Check both progressions before choosing the repack mode. If either
> leaves a pack above its split, geometric repack still avoids rewriting
> that pack, whereas the all-into-one fallback would rewrite it. Use the
> fallback only when neither progression leaves a pack behind. That
> preserves the reason for the fallback: let the all-into-one repack
> handle unreachable objects when it is not rewriting more packs than the
> geometric repack.

Okay. The consequence of the status quo could be that we perform an all-into-one repack more frequent than really desired because the set of non-promised packs is small, and thus even writing a small set of new objects could cause a full repack.

This might create the reverse situation though, where we don't perform the all-into-one repack at all anymore. We could come up with a clever solution here, like for example considering both sequences together and repacking when we cross a certain combined threshold. But I'm not sure it's worth it for now, and we can still evolve the strategy as needed.

Patrick
Previous: Taylor BlauNext: Taylor Blau
Message 3 of 10 in “maintenance: handle geometric repack tasks with promisor pack(s)”
  1. 0/2 maintenance: handle geometric repack tasks with promisor pack(s)Taylor Blau, Aug 5, 2026
  2. 1/2 maintenance: account for promisor pack geometryTaylor Blau, Aug 5, 2026
  3. Patrick SteinhardtAug 10, 2026
  4. Taylor BlauAug 10, 2026
  5. Patrick SteinhardtAug 11, 2026
  6. Taylor BlauAug 11, 2026
  7. Patrick SteinhardtAug 11, 2026
  8. 2/2 maintenance: trigger --auto for promisor rollupsTaylor Blau, Aug 5, 2026
  9. Patrick SteinhardtAug 10, 2026
  10. Taylor BlauAug 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.