git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 0/2] doc: clarify review replies and reroll timing

From
WYWeijie Yuan <wy@wyuan.org>
Date
Jun 13, 2026, 14:08 UTC
Message-ID
<cover.1781358364.git.wy@wyuan.org>
Hi,

This small series updates the 2 documentations: MyFirstContribution and SubmittingPatches.

The first patch clarifies that review feedback should not be answered only by sending a new version of the patches, which is talked in [1]. Contributors are encouraged to and should discuss their planned response in the existing review thread, so that the next version does not become the only place where reviewers can infer the author's reasoning.

The second patch is originally from an email from Patrick [2], which documents a rough expectation around reroll frequency.

Patrick suggests: There is no hard rule for when to send a new version, but batching feedback and avoiding multiple rerolls of the same series in a single day is a useful default. The text also mentions factors that may affect this, such as the size of the series, the depth of review, and whether the topic is close to being picked up.

Since I am the newbie here, please tell me how to attribute the credit to Patrick. Thank you Patrick!

I am sending this as RFC because I think my wording is quite rough, and there must be a better way to express all of these, including how to manage the structures of both these two documents. Any comments are appreciated, thank you!

[1]: <xmqq7bo5nf31.fsf@gitster.g> [2]: <aietF4BX1Ewt3cpG@pks.im>

Weijie Yuan (2):
  doc: encourage review replies before rerolling
  doc: advise batching patch rerolls
 Documentation/MyFirstContribution.adoc | 27 +++++++++++++++++++++-----
 Documentation/SubmittingPatches        | 17 +++++++++++++---
 2 files changed, 36 insertions(+), 8 deletions(-)
-- 
2.54.0
Next: Weijie Yuan
Message 1 of 22 in “doc: clarify review replies and reroll timing”
  1. 0/2 doc: clarify review replies and reroll timingWeijie Yuan, Jun 13, 2026
  2. 1/2 doc: encourage review replies before rerollingWeijie Yuan, Jun 13, 2026
  3. Patrick SteinhardtJun 15, 2026
  4. Weijie YuanJun 15, 2026
  5. 2/2 doc: advise batching patch rerollsWeijie Yuan, Jun 13, 2026
  6. Junio C HamanoJun 13, 2026
  7. Weijie YuanJun 13, 2026
  8. Patrick SteinhardtJun 15, 2026
  9. Weijie YuanJun 15, 2026
  10. 0/2 doc: clarify review replies and reroll timingWeijie Yuan, Jun 17, 2026
  11. 1/2 doc: encourage review replies before rerollingWeijie Yuan, Jun 17, 2026
  12. 2/2 doc: advise batching patch rerollsWeijie Yuan, Jun 17, 2026
  13. Junio C HamanoJun 17, 2026
  14. Weijie YuanJun 19, 2026
  15. Patrick SteinhardtJun 24, 2026
  16. Weijie YuanJun 25, 2026
  17. 0/2 doc: clarify review replies and reroll timingWeijie Yuan, Jun 21, 2026
  18. 1/2 doc: encourage review replies before rerollingWeijie Yuan, Jun 21, 2026
  19. 2/2 doc: advise batching patch rerollsWeijie Yuan, Jun 21, 2026
  20. Patrick SteinhardtJun 24, 2026
  21. Patrick SteinhardtJun 24, 2026
  22. Weijie YuanJun 25, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.