git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/2] doc: advise batching patch rerolls

From
Patrick Steinhardt <ps@pks.im>
Date
Jun 24, 2026, 11:46 UTC
Message-ID
<ajvDsy1qVCZoqiCu@pks.im>
In-Reply-To
<e1050a6ef5e26299b2c6d9743067fe3d7f4f8071.1782028813.git.wy@wyuan.org>
On Sun, Jun 21, 2026 at 04:05:34PM +0800, Weijie Yuan wrote:
Show 29 quoted lines
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index 00704ab91e..35105bc3b4 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -1330,6 +1330,28 @@ previous one" patches over 2 days), reviewers would strongly prefer if a
>  single polished version came 2 days later instead, and that version with
>  fewer mistakes were the only one they would need to review.
>  
> +This consideration applies not only when going from the initial patch to v2,
> +but also to later iterations of the same series. There is no fixed rule for how
> +long to wait before sending a new version. A useful default is to send at most
> +one new version of the same patch series per day. This gives multiple reviewers
> +time to comment, gives reviewers across time zones a fair chance to
> +participate, lets you batch feedback together, and gives you time to think
> +through the comments you received. Knowing that you should not immediately send
> +another version also encourages you to review the patches more carefully before
> +sending them, catch small mistakes such as typos and off-by-one errors
> +yourself, and let reviewers spend more of their attention on design,
> +algorithms, and other substantial issues.
> +
> +The right timing depends on the topic and the feedback. Larger series usually
> +need more review time. If the only comments so far are minor, such as typo
> +fixes, it often makes sense to wait a little longer in case deeper reviews are
> +still coming. If the comments call for substantial rework, do not rush out an
> +updated version before you have reviewed the larger changes carefully. Instead,
> +reply to the review that prompted the rewrite, say that you are preparing a
> +substantial rework, and mention which parts of the current series will become
> +obsolete so reviewers can avoid spending time on them until the updated series
> +is ready.
Makes sense.
Patrick
Previous: Weijie YuanNext: Patrick Steinhardt
Message 20 of 22 in “doc: clarify review replies and reroll timing”
  1. 0/2 doc: clarify review replies and reroll timingWeijie Yuan, Jun 13, 2026
  2. 1/2 doc: encourage review replies before rerollingWeijie Yuan, Jun 13, 2026
  3. Patrick SteinhardtJun 15, 2026
  4. Weijie YuanJun 15, 2026
  5. 2/2 doc: advise batching patch rerollsWeijie Yuan, Jun 13, 2026
  6. Junio C HamanoJun 13, 2026
  7. Weijie YuanJun 13, 2026
  8. Patrick SteinhardtJun 15, 2026
  9. Weijie YuanJun 15, 2026
  10. 0/2 doc: clarify review replies and reroll timingWeijie Yuan, Jun 17, 2026
  11. 1/2 doc: encourage review replies before rerollingWeijie Yuan, Jun 17, 2026
  12. 2/2 doc: advise batching patch rerollsWeijie Yuan, Jun 17, 2026
  13. Junio C HamanoJun 17, 2026
  14. Weijie YuanJun 19, 2026
  15. Patrick SteinhardtJun 24, 2026
  16. Weijie YuanJun 25, 2026
  17. 0/2 doc: clarify review replies and reroll timingWeijie Yuan, Jun 21, 2026
  18. 1/2 doc: encourage review replies before rerollingWeijie Yuan, Jun 21, 2026
  19. 2/2 doc: advise batching patch rerollsWeijie Yuan, Jun 21, 2026
  20. Patrick SteinhardtJun 24, 2026
  21. Patrick SteinhardtJun 24, 2026
  22. Weijie YuanJun 25, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.