Re: [RFC PATCH 2/2] doc: advise batching patch rerolls
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jun 15, 2026, 13:17 UTC
- Message-ID
- <ai_7X_QY0u1CWJ7s@pks.im>
- In-Reply-To
- <ai2NwMS-i_UTWR5T@wyuan.org>
On Sun, Jun 14, 2026 at 01:05:04AM +0800, Weijie Yuan wrote:
Show 38 quoted lines
> On Sat, Jun 13, 2026 at 09:02:39AM -0700, Junio C Hamano wrote: > > Weijie Yuan <wy@wyuan.org> writes: > > > > > Contributors often need guidance on how quickly to send later iterations > > > of a patch series. Add a rough default of no more than one new version > > > of the same series per day so feedback can be batched and reviewers have > > > time to comment. > > > > > > Mention factors that can affect the timing, such as series size, review > > > depth, substantial rework, and how close the topic is to being accepted. > > > > Another good thing to discourage yourself from rerolling too quickly > > is that such a practice forces you to think twice and be very > > careful before sending patches out. As you have only one chance to > > get it right before, say, 24 hours, you'd want to make sure that you > > would not distract your reviewers with stupid typoes, off-by-one > > errors, and such, and concentrate their reviews more on what matters > > more, i.e., the higher level design, choice of algorithms, etc. > > > > > +This consideration applies not only when going from the initial patch to v2, but > > > +also to later iterations of the same series. There is no fixed rule for how long > > > +to wait before sending a new version. A useful default is to send at most one > > > +new version of the same patch series per day. This gives multiple reviewers time > > > +to comment, lets you batch feedback together, and gives you time to think > > > +through the comments you received. > > > > And the 24-hour gives equal chance to comment on your patches to > > anybody no matter where they live ;-) > > Thanks for your comments above! Let me think about how to integrate > these contents with the patch. > > > I see you CC'ed Patrick, and I am sure he'll give us more useful > > suggestions than I do here ;-) > > This is his practical advice, and I just stole Patrick´s wording, to be > fair ;-) so of course I should CC him and let him know I am a wording > thief :-P, hope it wouldn't disturb him ;-)
Indeed, so I don't really have anything else to add here.
By the way, talking about mailing list etiquette: in scenarios like this it makes sense to add a Helped-by trailer. That would've serviced as hint to Junio that I was already involved, and it gives credit to that other contributor. I myself don't care much about the latter part anymore, but newer contributors might.
And no, I don't mind at all that you "stole" my wording. Quite on the contrary, I'm happy you picked up my thoughts and cared enough to put them into a nice patch series :)
Thanks!
Patrick