git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/4] pack-bitmap: enable lookup tables by default, misc. cleanups

From
Taylor Blau <me@ttaylorr.com>
Date
Apr 17, 2025, 21:12 UTC
Message-ID
<cover.1744924321.git.me@ttaylorr.com>

This is a short series I extracted from a larger topic on reusing "external"[^1] deltas during verbatim pack reuse.

As part of performance-testing that series, I realized that bitmap lookup tables are not written by default. Since it has been a significant period of time since their introduction, the first patch of this series makes writing the lookup table extension the default behavior. This is:

  * pack-bitmap: write lookup table extension by default

The next three patches clean up some t/perf scripts that were redundant now that lookup tables are the default behavior. Those are:

  * p5312: removed duplicate performance test script
  * t/perf: avoid testing bitmaps without lookup table
  * t/perf/lib-bitmap.sh: avoid test_perf during setup
Thanks in advance for your review :-).

[^1]: The term I'm using to describe delta/base pairs which either (a) are represented from different packs in a MIDX bitmap, or (b) the client is known to already have the base.

Taylor Blau (4):
  pack-bitmap: write lookup table extension by default
  p5312: removed duplicate performance test script
  t/perf: avoid testing bitmaps without lookup table
  t/perf/lib-bitmap.sh: avoid test_perf during setup
 Documentation/config/pack.adoc       |   2 +-
 builtin/multi-pack-index.c           |   1 +
 builtin/pack-objects.c               |   2 +-
 t/perf/lib-bitmap.sh                 |   2 +-
 t/perf/p5310-pack-bitmaps.sh         |  47 +++++-------
 t/perf/p5311-pack-bitmaps-fetch.sh   |  76 +++++++++----------
 t/perf/p5312-pack-bitmaps-revs.sh    |  34 ---------
 t/perf/p5326-multi-pack-bitmaps.sh   | 107 ++++++++++++---------------
 t/perf/p5333-pseudo-merge-bitmaps.sh |   1 -
 9 files changed, 106 insertions(+), 166 deletions(-)
 delete mode 100755 t/perf/p5312-pack-bitmaps-revs.sh
base-commit: c152ae3ef50dc7bbbf5089571df5bba404a96e0d
-- 
2.49.0.226.g0e6cae136d
Next: Taylor Blau
Message 1 of 18 in “pack-bitmap: enable lookup tables by default, misc. cleanups”
  1. 0/4 pack-bitmap: enable lookup tables by default, misc. cleanupsTaylor Blau, Apr 17, 2025
  2. 1/4 pack-bitmap: write lookup table extension by defaultTaylor Blau, Apr 17, 2025
  3. Junio C HamanoApr 17, 2025
  4. Jeff KingApr 18, 2025
  5. Junio C HamanoApr 18, 2025
  6. Taylor BlauApr 18, 2025
  7. 2/4 p5312: removed duplicate performance test scriptTaylor Blau, Apr 17, 2025
  8. Junio C HamanoApr 17, 2025
  9. Taylor BlauApr 18, 2025
  10. 3/4 t/perf: avoid testing bitmaps without lookup tableTaylor Blau, Apr 17, 2025
  11. Junio C HamanoApr 17, 2025
  12. Junio C HamanoApr 18, 2025
  13. Jeff KingApr 18, 2025
  14. 4/4 t/perf/lib-bitmap.sh: avoid test_perf during setupTaylor Blau, Apr 17, 2025
  15. Junio C HamanoApr 17, 2025
  16. Jeff KingApr 18, 2025
  17. Junio C HamanoMay 2, 2025
  18. Patrick SteinhardtMay 5, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.