git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] pack-bitmap: enable lookup tables by default, misc. cleanups

From
Patrick Steinhardt <ps@pks.im>
Date
May 5, 2025, 07:11 UTC
Message-ID
<aBhkjGtlA2N7yTVw@pks.im>
In-Reply-To
<xmqqfrhmu2s4.fsf@gitster.g>
On Fri, May 02, 2025 at 02:21:47PM -0700, Junio C Hamano wrote:
Show 34 quoted lines
> Taylor Blau <me@ttaylorr.com> writes:
> 
> > This is a short series I extracted from a larger topic on reusing
> > "external"[^1] deltas during verbatim pack reuse.
> >
> > As part of performance-testing that series, I realized that bitmap
> > lookup tables are not written by default. Since it has been a
> > significant period of time since their introduction, the first patch of
> > this series makes writing the lookup table extension the default
> > behavior. This is:
> >
> >   * pack-bitmap: write lookup table extension by default
> >
> > The next three patches clean up some t/perf scripts that were redundant
> > now that lookup tables are the default behavior. Those are:
> >
> >   * p5312: removed duplicate performance test script
> >   * t/perf: avoid testing bitmaps without lookup table
> >   * t/perf/lib-bitmap.sh: avoid test_perf during setup
> >
> > Thanks in advance for your review :-).
> >
> > [^1]: The term I'm using to describe delta/base pairs which either (a)
> > are represented from different packs in a MIDX bitmap, or (b) the client
> > is known to already have the base.
> >
> > Taylor Blau (4):
> >   pack-bitmap: write lookup table extension by default
> >   p5312: removed duplicate performance test script
> >   t/perf: avoid testing bitmaps without lookup table
> >   t/perf/lib-bitmap.sh: avoid test_perf during setup
> 
> Peff and I were the only two people who read these patches?
> Is this topic still viable, or has it been backburnered?

I read through the patch series, but didn't have anything to add over what has already been discussed. Overall I think that it makes sense to enable lookup tables -- we've had them enabled since February 2023 for all users of GitLab.

Patrick
Previous: Junio C Hamano
Message 18 of 18 in “pack-bitmap: enable lookup tables by default, misc. cleanups”
  1. 0/4 pack-bitmap: enable lookup tables by default, misc. cleanupsTaylor Blau, Apr 17, 2025
  2. 1/4 pack-bitmap: write lookup table extension by defaultTaylor Blau, Apr 17, 2025
  3. Junio C HamanoApr 17, 2025
  4. Jeff KingApr 18, 2025
  5. Junio C HamanoApr 18, 2025
  6. Taylor BlauApr 18, 2025
  7. 2/4 p5312: removed duplicate performance test scriptTaylor Blau, Apr 17, 2025
  8. Junio C HamanoApr 17, 2025
  9. Taylor BlauApr 18, 2025
  10. 3/4 t/perf: avoid testing bitmaps without lookup tableTaylor Blau, Apr 17, 2025
  11. Junio C HamanoApr 17, 2025
  12. Junio C HamanoApr 18, 2025
  13. Jeff KingApr 18, 2025
  14. 4/4 t/perf/lib-bitmap.sh: avoid test_perf during setupTaylor Blau, Apr 17, 2025
  15. Junio C HamanoApr 17, 2025
  16. Jeff KingApr 18, 2025
  17. Junio C HamanoMay 2, 2025
  18. Patrick SteinhardtMay 5, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.