[PATCH 4/4] t/perf/lib-bitmap.sh: avoid test_perf during setup
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Apr 17, 2025, 21:12 UTC
- Message-ID
- <0906e14c0e55b52573c7e0b632c7c639850700ec.1744924321.git.me@ttaylorr.com>
- In-Reply-To
- <cover.1744924321.git.me@ttaylorr.com>
In the test_pack_bitmap() helper function, we first repack the repository under test for consistency and to eliminate any effects from different distributions of objects among packs.
This step is performed with test_perf, so it is repeated $GIT_PERF_REPEAT_COUNT number of times. But we do not care about timing this portion of the setup phase, and repeating the process does not change the outcome.
Use test_expect_success to avoid spending time repeating an idempotent portion of the setup for performance tests that use test_pack_bitmap().
Signed-off-by: Taylor Blau <me@ttaylorr.com> --- t/perf/lib-bitmap.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/perf/lib-bitmap.sh b/t/perf/lib-bitmap.sh index 55a8feb1dc..fdf5f35f1b 100644 --- a/t/perf/lib-bitmap.sh +++ b/t/perf/lib-bitmap.sh @@ -69,7 +69,7 @@ test_partial_bitmap () { } test_pack_bitmap () { - test_perf "repack to disk" ' + test_expect_success "repack to disk" ' git repack -ad '
-- 2.49.0.226.g0e6cae136d